[beta] Add back Manifest::targets_mut#8534
Merged
alexcrichton merged 1 commit intorust-lang:rust-1.46.0from Jul 23, 2020
Merged
[beta] Add back Manifest::targets_mut#8534alexcrichton merged 1 commit intorust-lang:rust-1.46.0from
alexcrichton merged 1 commit intorust-lang:rust-1.46.0from
Conversation
It is needed by cargo-c, it was removed in df5cb70
|
r? @ehuss (rust_highfive has picked a reviewer for you, use r? to override) |
|
Member
|
Mind cherry-picking #8528 here to get green CI? |
Member
Author
|
Happy with whatever, just let me know. Do we expect these test failures to lead to problems when integrating into upstream (rust-lang/rust)? |
Member
|
Ah that's a good point, I think it's fine to just hit merge. I'll work on getting a green CI later for more backports. |
Member
|
Oh and these are all nightly-only tests so shouldn't cause issues in rust-lang/rust. |
Contributor
|
Oh, haha, sorry for giving conflicting advice! These won't fail in rust-lang/rust because they don't run there (all of our nightly-only tests are disabled on rust-lang/rust). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is needed by cargo-c, it was removed in df5cb70
This is coupled with stable backport approved yesterday, #8527.