Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from trim_right to trim_end #6417

Merged
merged 1 commit into from
Dec 11, 2018
Merged

Migrate from trim_right to trim_end #6417

merged 1 commit into from
Dec 11, 2018

Conversation

alexcrichton
Copy link
Member

The trim_right method is soon to be deprecated!

@alexcrichton
Migrate from trim_right to trim_end
9054b7c 
The `trim_right` method is soon to be deprecated!
@rust-highfive
Copy link

r? @dwijnand

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member Author

FWIW originally discovered in testing of rust-lang/rust#56536

@ehuss
Copy link
Contributor

ehuss commented Dec 11, 2018

@bors r+

@bors
Copy link
Contributor

bors commented Dec 11, 2018

📌 Commit 9054b7c has been approved by ehuss

bors added a commit that referenced this pull request Dec 11, 2018
@bors
Auto merge of #6417 - alexcrichton:deprecated, r=ehuss
2cf1f5d 
Migrate from trim_right to trim_end

The `trim_right` method is soon to be deprecated!
@bors
Copy link
Contributor

bors commented Dec 11, 2018

⌛ Testing commit 9054b7c with merge 2cf1f5d...

@bors
Copy link
Contributor

bors commented Dec 11, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: ehuss
Pushing 2cf1f5d to master...

@bors bors merged commit 9054b7c into rust-lang:master Dec 11, 2018
@Eh2406
Copy link
Contributor

Eh2406 commented Dec 11, 2018

If we can't merge with deprecated code, let's add it to our CI. How do we do that?

@dwijnand
Copy link
Member

Sorry, I've not had regular work days so I'm behind on all my notifications and didn't realise I'd been assigned. Thanks for picking this up @ehuss.

@ehuss
Copy link
Contributor

ehuss commented Dec 11, 2018

If we can't merge with deprecated code, let's add it to our CI. How do we do that?

I don't think we can in this case. It's a new deprecation in 1.33. Nightly is currently 1.32, and it was the PR bumping it to 1.33 that enabled the warning. This is just one of the frictions of using deny(warnings).

@alexcrichton alexcrichton deleted the deprecated branch December 11, 2018 21:41
@ehuss ehuss mentioned this pull request Jan 2, 2019
Merged
bors added a commit that referenced this pull request Jan 2, 2019
@bors
Auto merge of #6514 - ehuss:beta-fingerprint-patch, r=alexcrichton
8610973 
[BETA] Fix fingerprint calculation for patched deps.

Backport of #6493.
Also includes the following to pass CI:
- #6417
- Bump min version in CI for `trim_end`.
@ehuss ehuss modified the milestones: 1.33.0, 1.32.0 Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dwijnand dwijnand

Labels
None yet
Projects
None yet
Milestone
1.32.0
Development

Successfully merging this pull request may close these issues.
6 participants
@alexcrichton @rust-highfive @ehuss @bors @Eh2406 @dwijnand