Skip to content

Fix example for usage still not published uuid 2.0.0 #6006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2018

Conversation

EPashkin
Copy link
Contributor

IMHO There some inconsistency in https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#prepublishing-a-breaking-change
We have unpublished version 2.0.0 for uuid crate in branch with same name.
Now we can test it in my-library without waiting for publish as written in docs.
But if my-library changes committed to its master, for my-binary patch need be same as in library,
as uuid 2.0.0 still not published.

@alexcrichton
Copy link
Member

@bors: r+

Looks good to me, thanks!

@bors
Copy link
Contributor

bors commented Sep 11, 2018

📌 Commit 45dea14 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Sep 11, 2018

⌛ Testing commit 45dea14 with merge b0679d5...

bors added a commit that referenced this pull request Sep 11, 2018
Fix example for usage still not published uuid 2.0.0

IMHO There some inconsistency in https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#prepublishing-a-breaking-change
We have unpublished version 2.0.0 for uuid crate in branch with same name.
Now we can test it in `my-library` without waiting for publish as written in docs.
But if `my-library` changes committed to its master, for `my-binary` patch need be same as in library,
as uuid 2.0.0 still not published.
@bors
Copy link
Contributor

bors commented Sep 11, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing b0679d5 to master...

@bors bors merged commit 45dea14 into rust-lang:master Sep 11, 2018
@ehuss ehuss added this to the 1.31.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants