Skip to content

Rename the rust manifest key to edition #5472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2018
Merged

Rename the rust manifest key to edition #5472

merged 1 commit into from
May 3, 2018

Conversation

@alexcrichton
Copy link
Member

@alexcrichton alexcrichton commented May 3, 2018

This'll hopefully jive better with the terminology of "edition" throughout the
rest of Rust!

@rust-highfive
Copy link

rust-highfive commented May 3, 2018

r? @matklad

(rust_highfive has picked a reviewer for you, use r? to override)

@matklad
Copy link
Contributor

matklad commented May 3, 2018

I sort of like rust = 2018 more, because it is slightly more self-documenting. With edition, it is unclear what edition we are talking about. It can be confused with package edition or something.

@matklad
Copy link
Contributor

matklad commented May 3, 2018

But I don't have a strong opinion here, changes look good to me!

@alexcrichton
Copy link
Member Author

alexcrichton commented May 3, 2018

There's some discussion at https://gitter.im/rust-lang/WG-epoch?at=5aeb2d9653ceca3604ac3bae and https://paper.dropbox.com/doc/Edition-preview-cheat-sheet-HhfGRmTX4mByEOWWI2P7o, but I think the general consensus is towards edition rather than rust

@matklad
Copy link
Contributor

matklad commented May 3, 2018

Great!

@bors r+

@bors
Copy link
Contributor

bors commented May 3, 2018

📌 Commit 979e79e has been approved by matklad

ehuss
ehuss reviewed May 3, 2018
View reviewed changes
src/doc/src/reference/unstable.md Outdated
Copy link
Contributor

@ehuss ehuss May 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should probably say edition key (instead of rust) a couple lines above this.

Copy link
Contributor

@matklad matklad May 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent catch!

@matklad
Copy link
Contributor

matklad commented May 3, 2018

@bors r-

@alexcrichton
Rename the rust manifest key to edition
8413008 
This'll hopefully jive better with the terminology of "edition" throughout the
rest of Rust!
@alexcrichton
Copy link
Member Author

alexcrichton commented May 3, 2018

@bors: r=matklad

@bors
Copy link
Contributor

bors commented May 3, 2018

📌 Commit 8413008 has been approved by matklad

bors added a commit that referenced this pull request May 3, 2018
@bors
Auto merge of #5472 - alexcrichton:rename-rust, r=matklad
0dd5384 
Rename the `rust` manifest key to `edition`

This'll hopefully jive better with the terminology of "edition" throughout the
rest of Rust!
@bors
Copy link
Contributor

bors commented May 3, 2018

⌛ Testing commit 8413008 with merge 0dd5384...

@bors
Copy link
Contributor

bors commented May 3, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: matklad
Pushing 0dd5384 to master...

@bors bors merged commit 8413008 into rust-lang:master May 3, 2018
@alexcrichton alexcrichton deleted the rename-rust branch May 10, 2018 19:17
@ehuss ehuss added this to the 1.27.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ehuss ehuss ehuss left review comments

+1 more reviewer

@matklad matklad matklad left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@matklad matklad

Labels

None yet

Projects

None yet

Milestone

1.27.0

Development

Successfully merging this pull request may close these issues.

5 participants

@alexcrichton @rust-highfive @matklad @bors @ehuss