Explain why we need a Vec<Dependency> in Resolve.
#5459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ |
|
📌 Commit 20d8ff4 has been approved by |
|
⌛ Testing commit 20d8ff4 with merge e693a26f6352dcbcadf96174f7344c37a6043dee... |
|
💔 Test failed - status-appveyor |
|
@bors retry |
|
⌛ Testing commit 20d8ff4 with merge 876d4a86b6e1e84d0e3dfa6b559fb0bd18d29c1e... |
|
@bors: retry
…On Wed, May 2, 2018 at 1:56 PM, bors ***@***.***> wrote:
💔 Test failed - status-appveyor
<https://ci.appveyor.com/project/rust-lang-libs/cargo/build/1.0.4592>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5459 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95PuVKNeWlXjWDTqaFtqTReRmBQ4Hks5tugFrgaJpZM4TvpaN>
.
|
bors
added a commit
that referenced
this pull request
May 2, 2018
Explain why we need a `Vec<Dependency>` in `Resolve`. Looks like everyone, who sees it, asks the same question, so let's add an explanation! cc #5428 (comment)
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like everyone, who sees it, asks the same question, so let's add an explanation!
cc #5428 (comment)