Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profile Overrides (RFC #2282 Part 1) #5384

Merged
merged 23 commits into from
Apr 27, 2018
Merged

Profile Overrides (RFC #2282 Part 1) #5384

merged 23 commits into from
Apr 27, 2018

Commits on Apr 27, 2018

  1. Profile Overrides (RFC rust-lang#2282 Part 1)

    @ehuss
    ehuss committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    575d6e8 View commit details
    Browse the repository at this point in the history

  2. Minor cleanup.

    @ehuss
    ehuss committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    62d6f0d View commit details
    Browse the repository at this point in the history

  3. Move Profile back into Unit as a copy. 

    The de-duplication of Units just doesn't work without it.
    @ehuss
    ehuss committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    7366074 View commit details
    Browse the repository at this point in the history

  4. Fix a variety of profile bugs.

    @ehuss
    ehuss committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    138eb33 View commit details
    Browse the repository at this point in the history

  5. Update for some review comments.

    @ehuss
    ehuss committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    7051b63 View commit details
    Browse the repository at this point in the history

  6. Add extra rustc/rustdoc args to the fingerprint and metadata.

    @ehuss
    ehuss committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    768f573 View commit details
    Browse the repository at this point in the history

  7. Avoid running build.rs too often.

    @ehuss
    ehuss committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    0d8ebe9 View commit details
    Browse the repository at this point in the history

  8. Minor tweaks on how examples are handled with tests, and some panic p… 

    …ropagation.
    @ehuss
    ehuss committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    7dc9e07 View commit details
    Browse the repository at this point in the history

  9. Add warnings for unknown profile overrides.

    @ehuss
    ehuss committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    a0a880c View commit details
    Browse the repository at this point in the history

  10. Add warning if panic is set in test or bench profile.

    @ehuss
    ehuss committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    36b8769 View commit details
    Browse the repository at this point in the history

  11. Add test for profile override on non-dev/release.

    @ehuss
    ehuss committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    ba537d7 View commit details
    Browse the repository at this point in the history

  12. Add more profile override validation tests.

    @ehuss
    ehuss committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    c667fc2 View commit details
    Browse the repository at this point in the history

  13. Some test cleanup for profiles.

    @ehuss
    ehuss committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    ec7be84 View commit details
    Browse the repository at this point in the history

  14. Remove last TODO comments.

    @ehuss
    ehuss committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    accc9b2 View commit details
    Browse the repository at this point in the history

  15. rustfmt

    @ehuss
    ehuss committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    a4947c2 View commit details
    Browse the repository at this point in the history

  16. Move profile override tests to a dedicated file.

    @ehuss
    ehuss committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    9ca36de View commit details
    Browse the repository at this point in the history

  17. Add thorough tests for target/profile selection.

    @ehuss
    ehuss committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    10a6da6 View commit details
    Browse the repository at this point in the history

  18. Add some more tests.

    @ehuss
    ehuss committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    b9181ef View commit details
    Browse the repository at this point in the history

  19. Update tests now that cargo check does not re-check bins.

    @ehuss
    ehuss committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    025e23b View commit details
    Browse the repository at this point in the history

  20. Avoid building libs and bins twice in `cargo build --all-targets --re… 

    …lease`.

This changes it so that `Build` mode is not set in the Unit, since there is
no difference between Bench and Test once the profile has been selected.
    @ehuss
    ehuss committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    195520b View commit details
    Browse the repository at this point in the history

  21. Fix Unit/Context parameter order.

    @ehuss
    ehuss committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    902cb98 View commit details
    Browse the repository at this point in the history

  22. Comment why deps_of doesn't need to keep track of profile_for in … 

    …map.
    @ehuss
    ehuss committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    040f984 View commit details
    Browse the repository at this point in the history

  23. Minor style update.

    @ehuss
    ehuss committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    e82e9c1 View commit details
    Browse the repository at this point in the history