Fix an infinite loop in error reporting #4806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `path_to_root` function unfortunately didn't account for cycles in the dependency graph introduced through dev-dependencies, so if a cycle was present then the function would infinitely loop pushing items onto a vector. This commit fixes the infinite loop and also touches up the reporting to be a little more consistent with the rest of Cargo
|
r? @matklad (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ Hm, another place where we do tree walking is when traversing directories upwards. in theory, we might hit a cycle there as well because of links. |
|
📌 Commit 4f0b8f8 has been approved by |
|
⌛ Testing commit 4f0b8f8 with merge 792ee85670db56e6adaf50c0143d989b4bb838fe... |
|
⌛ Testing commit 4f0b8f8 with merge 5b905422cb44d7ee50fdfd5806ee2e6a336f85ab... |
|
💔 Test failed - status-travis |
|
@bors: retry
…On Mon, Dec 11, 2017 at 7:04 AM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/cargo/builds/314757042?utm_source=github_status&utm_medium=notification>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#4806 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95PdzBrXGE3mZAF_UB6bHa6_Zl_Hoks5s_ShFgaJpZM4Q8loO>
.
|
bors
added a commit
that referenced
this pull request
Dec 12, 2017
Fix an infinite loop in error reporting The `path_to_root` function unfortunately didn't account for cycles in the dependency graph introduced through dev-dependencies, so if a cycle was present then the function would infinitely loop pushing items onto a vector. This commit fixes the infinite loop and also touches up the reporting to be a little more consistent with the rest of Cargo
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
path_to_rootfunction unfortunately didn't account for cycles in thedependency graph introduced through dev-dependencies, so if a cycle was present
then the function would infinitely loop pushing items onto a vector.
This commit fixes the infinite loop and also touches up the reporting to be a
little more consistent with the rest of Cargo