Generate .hgignore with syntax:glob #4158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ |
|
📌 Commit 1ec8936 has been approved by |
|
⌛ Testing commit 1ec8936 with merge 727a7b9... |
|
💔 Test failed - status-appveyor |
|
@bors: retry |
bors
added a commit
that referenced
this pull request
Jun 14, 2017
Generate .hgignore with syntax:glob Fixes #4005
|
☀️ Test successful - status-appveyor, status-travis |
sunshowers
added a commit
to sunshowers/cargo
that referenced
this pull request
Jul 31, 2017
There was an attempt to fix hgignore in rust-lang#4158, but unfortunately the fix was incorrect -- hgignore glob syntax is not in fact identical to gitignore syntax. To get rooted ignores in Mercurial we must use the regex-based syntax, so we have no choice but to define a separate set of ignores.
bors
added a commit
that referenced
this pull request
Jul 31, 2017
new: fix hgignore for real There was an attempt to fix hgignore in #4158, but unfortunately the fix was incorrect -- hgignore glob syntax is not in fact identical to gitignore syntax. To get rooted ignores in Mercurial we must use the regex-based syntax, so we have no choice but to define a separate set of ignores.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4005