Skip to content

Add a check for names starting with a digit #3542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2017
Merged

Add a check for names starting with a digit #3542

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/cargo/ops/cargo_new.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,13 @@ fn check_name(name: &str) -> CargoResult<()> {
name)
}

if let Some(ref c) = name.chars().nth(0) {
Copy link
Contributor

@lambda-fairy lambda-fairy Jan 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better style to use .next() here instead of .nth(0)?

Copy link
Contributor

@lambda-fairy lambda-fairy Jan 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, char is Copy so we don't need the ref here

if c.is_digit(10) {
bail!("Package names starting with a digit cannot be used as a crate name\n\
use --name to override crate name")
}
}

for c in name.chars() {
if c.is_alphanumeric() { continue }
if c == '_' || c == '-' { continue }
Expand Down