Repository navigation
fix(min-publish-age): remove registry.min-publish-age - #17353
Merged
Merged
Conversation
Collaborator
|
r? @epage rustbot has assigned @epage. Use Why was this reviewer chosen?The reviewer was selected based on:
|
epage
approved these changes
Aug 12, 2026
epage
enabled auto-merge
August 12, 2026 14:46
Member
Author
Hmm, it seems to discover a real bug. |
This is a preparataion of removing `registry.min-publish-age` support. After the change, it introduces a non-deterministic behavior that crates-io from alt-registry races with built-in crate-io Source in `SOURCE_ID_CACHE`, hence the ignore.
Our crates.io source ID has two forms: One with al_registry_key name and one without. `SOURCE_ID_CACHE` hold only one instance of them, so there may be a race. We need to fall back if missing one.
weihanglo
force-pushed
the
remove-min-publish-age
branch
from
August 12, 2026 16:56
6c20332 to
7c697f7
Compare
This caused some confusions. Better to stabilize min-publish-age configs incrementally. The main one-way-door we will take here is the agreement on the `global-` prefix for global settings in the `[registry]` table. For more discussions, see https://rust-lang.zulipchat.com/#narrow/channel/246057-t-cargo/topic/.5Bregistry.5D.20vs.20.5Bregistries.2Ecrates-io.5D/with/616084717
weihanglo
force-pushed
the
remove-min-publish-age
branch
from
August 12, 2026 16:59
7c697f7 to
8e55002
Compare
epage
approved these changes
Aug 12, 2026
Member
Author
Fixed by a fallback. Non-deterministic hashmap + our SourceId hash key impl strike again. |
This was referenced Aug 12, 2026
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Aug 15, 2026
Update cargo submodule 6 commits in eb98b54bc9f3c74519f43d066cb3fd02ebc88df0..8a0d8afba810304bcf9a10bac430be80dd470233 2026-08-11 16:00:29 +0000 to 2026-08-15 01:32:53 +0000 - chore: update to cc@1.4.3 (rust-lang/cargo#17364) - Remove most trailing whitespace across cargo (particularly markdown) (rust-lang/cargo#17358) - Remove unremap file when running cargo clean -p in new build-dir layout (rust-lang/cargo#17356) - fix(update)!: Remove unstable `--breaking` (rust-lang/cargo#17333) - docs: adopt rust-lang/rust's LLM usage policy (rust-lang/cargo#17330) - fix(min-publish-age): remove `registry.min-publish-age` (rust-lang/cargo#17353) r? ghost
renovate-bot
pushed a commit
to renovate-bot/rust-lang-_-compiler-builtins
that referenced
this pull request
Aug 17, 2026
Update cargo submodule 6 commits in eb98b54bc9f3c74519f43d066cb3fd02ebc88df0..8a0d8afba810304bcf9a10bac430be80dd470233 2026-08-11 16:00:29 +0000 to 2026-08-15 01:32:53 +0000 - chore: update to cc@1.4.3 (rust-lang/cargo#17364) - Remove most trailing whitespace across cargo (particularly markdown) (rust-lang/cargo#17358) - Remove unremap file when running cargo clean -p in new build-dir layout (rust-lang/cargo#17356) - fix(update)!: Remove unstable `--breaking` (rust-lang/cargo#17333) - docs: adopt rust-lang/rust's LLM usage policy (rust-lang/cargo#17330) - fix(min-publish-age): remove `registry.min-publish-age` (rust-lang/cargo#17353) r? ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
This caused some confusions.
Better to stabilize min-publish-age configs incrementally.
The main one-way-door we will take here is the agreement on the
global-prefix for global settings in the[registry]table. For more discussions, seehttps://rust-lang.zulipchat.com/#narrow/channel/246057-t-cargo/topic/.5Bregistry.5D.20vs.20.5Bregistries.2Ecrates-io.5D/with/616084717
How to test and review this PR?
CI passes.