Skip to content

feat(resolver): Report the min-publish-age in the lock message - #17328

Merged
weihanglo merged 4 commits into
rust-lang:masterfrom
epage:lock-min-publish
Aug 7, 2026
Merged

feat(resolver): Report the min-publish-age in the lock message#17328
weihanglo merged 4 commits into
rust-lang:masterfrom
epage:lock-min-publish

Conversation

@epage

@epage epage commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

What does this PR try to resolve?

One of the concerns is can we be transparent about how things are resolving. We are already helped by

  • error messages
  • listing unused dependencies and how old they are

Now we'll report what the unused dependency is compared against.

Part of #17009

How to test and review this PR?

This is stacked on #17327

@rustbot rustbot added A-dependency-resolution Area: dependency resolution and the resolver Command-add Command-update S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 6, 2026
@rustbot

rustbot commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

r? @weihanglo

rustbot has assigned @weihanglo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @epage, @weihanglo
  • @epage, @weihanglo expanded to epage, weihanglo

@epage
epage force-pushed the lock-min-publish branch 2 times, most recently from e4d3e2b to 43f89ce Compare August 7, 2026 14:05
@rustbot

rustbot commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@weihanglo weihanglo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. Thanks for the enhancement.

The only minor concern is that the locking message becomes a bit longer 😞.

View changes since this review

@weihanglo
weihanglo enabled auto-merge August 7, 2026 14:28
@weihanglo
weihanglo added this pull request to the merge queue Aug 7, 2026
Merged via the queue into rust-lang:master with commit 43d5282 Aug 7, 2026
29 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 7, 2026
@epage
epage deleted the lock-min-publish branch August 7, 2026 16:18
rust-bors Bot pushed a commit to rust-lang/rust that referenced this pull request Aug 8, 2026
Update cargo submodule

14 commits in c79e8f89441b3e73d6d65d125c0c745792808c74..b07e5a08651da80108eb65d7dc769ee04589f9bf
2026-08-04 19:17:33 +0000 to 2026-08-07 21:51:16 +0000
- feat(profile): Add built-in profile debug  (rust-lang/cargo#17214)
- feat(toml): allow overriding inherited default-features in 2024 (rust-lang/cargo#17126)
- feat(resolver): Report the min-publish-age in the lock message (rust-lang/cargo#17328)
- refactor(resolver): resolve() does not need an optional gctx (rust-lang/cargo#17331)
- fix(resolver): Make min-publish-age relative to --publish-time  (rust-lang/cargo#17327)
- test(trim-paths): exercise unremap files with debuggers (rust-lang/cargo#17326)
- feat(log): emit build-started JSON message with run_id  (rust-lang/cargo#16632)
- docs: remove stray `directory` metavar from `cargo update --breaking` option (rust-lang/cargo#17319)
- fix(lock): Use more accurate 'highest, rather than 'latest' (rust-lang/cargo#17317)
- docs(changelog): Pull the --verbose item (rust-lang/cargo#17315)
- revert(compiler): forward verbose flag to rustc for local crates (rust-lang/cargo#17314)
- fix(diag): Gate blanket_hint_mostly_unused with -Zprofile-hint-mostly-unused (rust-lang/cargo#17313)
- fix(diag): Remove complexity, perf, and nursery lint groups (rust-lang/cargo#17307)
- fix(git): Avoid use of git's core.fsmonitor (rust-lang/cargo#17306)

r? ghost
@rustbot rustbot added this to the 1.99.0 milestone Aug 8, 2026
pull Bot pushed a commit to LeeeeeeM/miri that referenced this pull request Aug 9, 2026
Update cargo submodule

14 commits in c79e8f89441b3e73d6d65d125c0c745792808c74..b07e5a08651da80108eb65d7dc769ee04589f9bf
2026-08-04 19:17:33 +0000 to 2026-08-07 21:51:16 +0000
- feat(profile): Add built-in profile debug  (rust-lang/cargo#17214)
- feat(toml): allow overriding inherited default-features in 2024 (rust-lang/cargo#17126)
- feat(resolver): Report the min-publish-age in the lock message (rust-lang/cargo#17328)
- refactor(resolver): resolve() does not need an optional gctx (rust-lang/cargo#17331)
- fix(resolver): Make min-publish-age relative to --publish-time  (rust-lang/cargo#17327)
- test(trim-paths): exercise unremap files with debuggers (rust-lang/cargo#17326)
- feat(log): emit build-started JSON message with run_id  (rust-lang/cargo#16632)
- docs: remove stray `directory` metavar from `cargo update --breaking` option (rust-lang/cargo#17319)
- fix(lock): Use more accurate 'highest, rather than 'latest' (rust-lang/cargo#17317)
- docs(changelog): Pull the --verbose item (rust-lang/cargo#17315)
- revert(compiler): forward verbose flag to rustc for local crates (rust-lang/cargo#17314)
- fix(diag): Gate blanket_hint_mostly_unused with -Zprofile-hint-mostly-unused (rust-lang/cargo#17313)
- fix(diag): Remove complexity, perf, and nursery lint groups (rust-lang/cargo#17307)
- fix(git): Avoid use of git's core.fsmonitor (rust-lang/cargo#17306)

r? ghost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-dependency-resolution Area: dependency resolution and the resolver Command-add Command-update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants