fix(clean): respect build.target config for clean -p#16988
Merged
Conversation
rustbot
added
the
S-waiting-on-review
Collaborator
|
r? @weihanglo rustbot has assigned @weihanglo. Use Why was this reviewer chosen?The reviewer was selected based on:
|
rustbot
removed
the
S-waiting-on-review
rustbot
added
the
S-waiting-on-review
Captures the current behavior where `cargo clean -p <pkg>` ignores the `build.target` config and reports 0 files, even though the build produced target-specific artifacts. See rust-lang#16974.
`clean_specs` resolves the requested kinds via `from_requested_targets`, which already falls back to `build.target` when no `--target` is passed. However, the layout selection then re-checked the raw CLI `targets` vec and dropped down to the host layout whenever `--target` was absent, ignoring the config fallback. Switch the check to `target_layouts.is_empty()` so a config-only target selects the target layouts, matching `--target` and the behavior documented for `cargo clean`. Fixes rust-lang#16974
0xPoe
commented
May 11, 2026
Member
Author
There was a problem hiding this comment.
🔢 Self-check (PR reviewed by myself and ready for feedback)
-
Code compiles successfully
-
Unit tests added
-
No AI-generated elegant nonsense in PR.
-
Comments added where necessary
-
PR title and description updated
-
Documentation PR created (or confirmed not needed)
-
PR size is reasonable
weihanglo
approved these changes
May 13, 2026
Member
There was a problem hiding this comment.
This is a reasonable fix, though it is changing the behavior of cargo clean with a slightly hard-to-notice way that people may not even realize they have configured build.target in the Cargo configuration file. We should probably put this under Cargo's own compatibility notice in Changelog
Thanks for the fix anyway.
rustbot
removed
the
S-waiting-on-review
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
May 16, 2026
Update cargo submodule 7 commits in a343accce8526b128adc517d33348573d22920a3..4d1f984518c77fad6eeef4f40153b002a659e662 2026-05-08 22:41:35 +0000 to 2026-05-15 17:12:01 +0000 - Revert "feat: add frame-pointers profile option (rust-lang/cargo#16742)" (rust-lang/cargo#16999) - CI: update to macos-15 (rust-lang/cargo#16996) - fix(clean): respect `build.target` config for `clean -p` (rust-lang/cargo#16988) - fix(diag): Consolidate verify/run diagnostics passes (rust-lang/cargo#16989) - fix(diag): Track Cargo diagnostic warning/error count like is done for rustc (rust-lang/cargo#16981) - fix: suggest 'fmt' when user types 'cargo rustfmt' (rust-lang/cargo#16985) - Rebuild when -Zpublic-dependency changes (rust-lang/cargo#16965) r? ghost
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
May 16, 2026
Update cargo submodule 7 commits in a343accce8526b128adc517d33348573d22920a3..4d1f984518c77fad6eeef4f40153b002a659e662 2026-05-08 22:41:35 +0000 to 2026-05-15 17:12:01 +0000 - Revert "feat: add frame-pointers profile option (rust-lang/cargo#16742)" (rust-lang/cargo#16999) - CI: update to macos-15 (rust-lang/cargo#16996) - fix(clean): respect `build.target` config for `clean -p` (rust-lang/cargo#16988) - fix(diag): Consolidate verify/run diagnostics passes (rust-lang/cargo#16989) - fix(diag): Track Cargo diagnostic warning/error count like is done for rustc (rust-lang/cargo#16981) - fix: suggest 'fmt' when user types 'cargo rustfmt' (rust-lang/cargo#16985) - Rebuild when -Zpublic-dependency changes (rust-lang/cargo#16965) r? ghost
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
May 17, 2026
Update cargo submodule 7 commits in a343accce8526b128adc517d33348573d22920a3..4d1f984518c77fad6eeef4f40153b002a659e662 2026-05-08 22:41:35 +0000 to 2026-05-15 17:12:01 +0000 - Revert "feat: add frame-pointers profile option (rust-lang/cargo#16742)" (rust-lang/cargo#16999) - CI: update to macos-15 (rust-lang/cargo#16996) - fix(clean): respect `build.target` config for `clean -p` (rust-lang/cargo#16988) - fix(diag): Consolidate verify/run diagnostics passes (rust-lang/cargo#16989) - fix(diag): Track Cargo diagnostic warning/error count like is done for rustc (rust-lang/cargo#16981) - fix: suggest 'fmt' when user types 'cargo rustfmt' (rust-lang/cargo#16985) - Rebuild when -Zpublic-dependency changes (rust-lang/cargo#16965) r? ghost
pull Bot
pushed a commit
to Kokoro2336/rust-analyzer
that referenced
this pull request
May 17, 2026
Update cargo submodule 7 commits in a343accce8526b128adc517d33348573d22920a3..4d1f984518c77fad6eeef4f40153b002a659e662 2026-05-08 22:41:35 +0000 to 2026-05-15 17:12:01 +0000 - Revert "feat: add frame-pointers profile option (rust-lang/cargo#16742)" (rust-lang/cargo#16999) - CI: update to macos-15 (rust-lang/cargo#16996) - fix(clean): respect `build.target` config for `clean -p` (rust-lang/cargo#16988) - fix(diag): Consolidate verify/run diagnostics passes (rust-lang/cargo#16989) - fix(diag): Track Cargo diagnostic warning/error count like is done for rustc (rust-lang/cargo#16981) - fix: suggest 'fmt' when user types 'cargo rustfmt' (rust-lang/cargo#16985) - Rebuild when -Zpublic-dependency changes (rust-lang/cargo#16965) r? ghost
pull Bot
pushed a commit
to xtqqczze/rust-lang-miri
that referenced
this pull request
May 20, 2026
Update cargo submodule 7 commits in a343accce8526b128adc517d33348573d22920a3..4d1f984518c77fad6eeef4f40153b002a659e662 2026-05-08 22:41:35 +0000 to 2026-05-15 17:12:01 +0000 - Revert "feat: add frame-pointers profile option (rust-lang/cargo#16742)" (rust-lang/cargo#16999) - CI: update to macos-15 (rust-lang/cargo#16996) - fix(clean): respect `build.target` config for `clean -p` (rust-lang/cargo#16988) - fix(diag): Consolidate verify/run diagnostics passes (rust-lang/cargo#16989) - fix(diag): Track Cargo diagnostic warning/error count like is done for rustc (rust-lang/cargo#16981) - fix: suggest 'fmt' when user types 'cargo rustfmt' (rust-lang/cargo#16985) - Rebuild when -Zpublic-dependency changes (rust-lang/cargo#16965) r? ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
Fixes #16974.
cargo clean -pignoredbuild.targetconfig.clean_specsresolvesrequested_kindswith the config fallback, but the layout selection rechecked the raw CLItargetsvec instead. Switched to checkingtarget_layouts.is_empty().How should we test and review this PR?
Two commits: a test capturing the buggy
Summary 0 filesoutput, then a one-line fix that flips the test expectation.