Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: make path arguments more generic and flexible #14979

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

weihanglo
Copy link
Member

What does this PR try to resolve?

So we don't need to p.to_str().unwrap()
and are able to pass different types for each argument

How should we test and review this PR?

No response.

So we don't need to `p.to_str().unwrap()`
and are able to pass different types for each argument
@rustbot
Copy link
Collaborator

rustbot commented Dec 24, 2024

r? @epage

rustbot has assigned @epage.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testing-cargo-itself Area: cargo's tests S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 24, 2024
@epage epage enabled auto-merge December 24, 2024 15:42
@epage epage added this pull request to the merge queue Dec 24, 2024
Merged via the queue into rust-lang:master with commit 4945803 Dec 24, 2024
20 checks passed
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 25, 2024
Update cargo

6 commits in 652623b779c88fe44afede28bf7f1c9c07812511..c86f4b3a1b153218e6e50861214b0b4b4e695f23
2024-12-20 15:44:42 +0000 to 2024-12-24 17:49:48 +0000
- fix(package): check dirtiness of path fields in manifest (rust-lang/cargo#14966)
- test: make path arguments more generic and flexible (rust-lang/cargo#14979)
- Moved manifest metadata tracking from fingerprint to dep info (rust-lang/cargo#14973)
- fix: assure possibly blocking non-files (like FIFOs) won't be picked up for publishing. (rust-lang/cargo#14977)
- simplify SourceID Hash (rust-lang/cargo#14800)
- upgrade `gix` to the latest release 0.69. (rust-lang/cargo#14975)
@rustbot rustbot added this to the 1.85.0 milestone Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testing-cargo-itself Area: cargo's tests S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants