Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate cargo verify-project #14736

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

MoskalykA
Copy link
Contributor

What does this PR try to resolve?

Information is available in the following issue #14679

Additional information

Closes #14679

@rustbot
Copy link
Collaborator

rustbot commented Oct 27, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @epage (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added A-cli Area: Command-line interface, option parsing, etc. A-documenting-cargo-itself Area: Cargo's documentation Command-verify-project S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. A-cli-help Area: built-in command-line help labels Oct 27, 2024
@MoskalykA MoskalykA force-pushed the deprecate-cargo-verify-project branch from 03f27d0 to 9de7e26 Compare October 27, 2024 20:22
@MoskalykA MoskalykA force-pushed the deprecate-cargo-verify-project branch from 05d63a5 to ccb674c Compare October 27, 2024 23:46
@MoskalykA MoskalykA force-pushed the deprecate-cargo-verify-project branch from ccb674c to 7a517af Compare October 28, 2024 00:30
@weihanglo
Copy link
Member

Thanks for the contribution!

@bors r+

@bors
Copy link
Contributor

bors commented Oct 28, 2024

📌 Commit 7a517af has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 28, 2024
@bors
Copy link
Contributor

bors commented Oct 28, 2024

⌛ Testing commit 7a517af with merge 30cc529...

bors added a commit that referenced this pull request Oct 28, 2024
…ihanglo

Deprecate `cargo verify-project`

### What does this PR try to resolve?

Information is available in the following issue #14679

### Additional information

Closes #14679
@bors
Copy link
Contributor

bors commented Oct 28, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 28, 2024
@MoskalykA
Copy link
Contributor Author

@weihanglo failed to connect to github.com: Connection timed out we just need to re-launch the bors tests?

@weihanglo
Copy link
Member

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 28, 2024
@bors
Copy link
Contributor

bors commented Oct 28, 2024

⌛ Testing commit 7a517af with merge eb2be13...

@bors
Copy link
Contributor

bors commented Oct 28, 2024

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing eb2be13 to master...

@bors bors merged commit eb2be13 into rust-lang:master Oct 28, 2024
22 checks passed
@MoskalykA MoskalykA deleted the deprecate-cargo-verify-project branch October 31, 2024 20:26
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 2, 2024
Update cargo

18 commits in e75214ea4936d2f2c909a71a1237042cc0e14b07..0310497822a7a673a330a5dd068b7aaa579a265e
2024-10-25 16:34:32 +0000 to 2024-11-01 19:27:56 +0000
- Add more metadata to `rustc_fingerprint` (rust-lang/cargo#14761)
- test(rustfix): switch to a simpler case for dedup-suggestions (rust-lang/cargo#14765)
- chore(deps): update rust crate security-framework to v3 (rust-lang/cargo#14766)
- chore(deps): update rust crate gix to 0.67.0 (rust-lang/cargo#14762)
- fix(util): Respect all `..`s in `normalize_path` (rust-lang/cargo#14750)
- test(doc): Resolve flaky test (rust-lang/cargo#14760)
- refactor(test): Remove dead 'expect_stdout_contains_n' check (rust-lang/cargo#14759)
- add unstable -Zroot-dir flag to configure the path from which rustc should be invoked (rust-lang/cargo#14752)
- docs(resolver): Further v3 prep (rust-lang/cargo#14753)
- fix: track version in fingerprint dep-info files (rust-lang/cargo#14751)
- test: Remove unused msrv-policy (rust-lang/cargo#14748)
- download targeted transitive deps of with artifact deps'  target platform (rust-lang/cargo#14723)
- Remove requirement for --target when invoking Cargo with -Zbuild-std (rust-lang/cargo#14317)
- docs(fingerprint): document the encoding of Cargo's depinfo (rust-lang/cargo#14745)
- Allow build scripts to report error messages through `cargo::error` (rust-lang/cargo#14743)
- fix(publish): Downgrade version-exists error to warning on dry-run (rust-lang/cargo#14742)
- fix: clean up for deprecated and removed commands (rust-lang/cargo#14739)
- Deprecate `cargo verify-project` (rust-lang/cargo#14736)
@rustbot rustbot added this to the 1.84.0 milestone Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Area: Command-line interface, option parsing, etc. A-cli-help Area: built-in command-line help A-documenting-cargo-itself Area: Cargo's documentation Command-verify-project S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate cargo verify-project
5 participants