Skip to content

docs: install options -> uninstall options #14682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2024
Merged

docs: install options -> uninstall options #14682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/doc/man/cargo-uninstall.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ By default all binaries are removed for a crate but the `--bin` and

## OPTIONS

### Install Options
### Uninstall Options

{{#options}}

Expand Down
2 changes: 1 addition & 1 deletion src/doc/man/generated_txt/cargo-uninstall.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ DESCRIPTION
o $HOME/.cargo

OPTIONS
Install Options
Uninstall Options
-p, --package spec…
Package to uninstall.

Expand Down
2 changes: 1 addition & 1 deletion src/doc/src/commands/cargo-uninstall.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ The installation root is determined, in order of precedence:

## OPTIONS

### Install Options
### Uninstall Options
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

This markdown file is generated. You'll need to update the manpage template instead:

cargo/src/doc/man/cargo-uninstall.md

Line 24 in 82c489f

### Install Options

See also the doc contribution guide: https://github.com/rust-lang/cargo/tree/master/src/doc#building-the-man-pages

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback!

I moved the typo to the correct file.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you squash commits into one? We would like to keep every commit passing CI if possible.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will! Thanks for your patience!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @weihanglo, is there any way for me to stop the CI when I know that it's going to fail? It seems wasteful to run the full pipeline in that case.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Push a new rev and the old one will get cancelled.

cargo/.github/workflows/main.yml

Lines 19 to 21 in 82c489f

concurrency:
group: "${{ github.workflow }}-${{ (github.ref == 'refs/heads/try' && github.sha) || github.ref }}"
cancel-in-progress: true


<dl>

Expand Down
2 changes: 1 addition & 1 deletion src/etc/man/cargo-uninstall.1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ The installation root is determined, in order of precedence:
\h'-04'\(bu\h'+02'\fB$HOME/.cargo\fR
.RE
.SH "OPTIONS"
.SS "Install Options"
.SS "Uninstall Options"
.sp
\fB\-p\fR,
\fB\-\-package\fR \fIspec\fR\[u2026]
Expand Down
Loading