test: Add test codebase for shell completions #14681
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pletions` Passing `cwd` to custom completion functions makes that we could generate completions in the template project.
- Add an empty template project, which is used for building test cases - Add a format function used for completions result
- Sort the order of example candidates by the way
rustbot
added
A-cli
epage
reviewed
Oct 31, 2024
| @@ -45,7 +45,7 @@ pub fn exec(gctx: &mut GlobalContext, args: &ArgMatches) -> CliResult { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| fn get_installed_crates() -> Vec<clap_complete::CompletionCandidate> { | |||
| pub fn get_installed_crates() -> Vec<clap_complete::CompletionCandidate> { | |||
There was a problem hiding this comment.
This being pub doesn't make a difference as this only exists in the bin
epage
reviewed
Oct 31, 2024
| @@ -0,0 +1,15 @@ | |||
| #![allow(unused)] | |||
| fn print_candidates(candidates: Vec<clap_complete::CompletionCandidate>) -> String { | |||
There was a problem hiding this comment.
render_candidates since this doesn't print to stdout/stderr
epage
reviewed
Oct 31, 2024
Comment on lines
+8
to
+10
| let current_dir = std::env::current_dir().expect("Failed to get current directory"); | ||
| let cwd = PathBuf::from(file!()).parent().unwrap().join("template"); | ||
| let cwd = current_dir.join(cwd); |
There was a problem hiding this comment.
A temp directory is created for each test. I'd recommend going ahead and writing to that and using that as the "cwd" for the test case. We have ProjectBuilder to help in creating these. You can also publish packages to a dev registry.
epage
reviewed
Oct 31, 2024
| @@ -1104,14 +1105,15 @@ pub fn get_registry_candidates( | |||
| { | |||
| Ok(registries | |||
| .keys() | |||
| .sorted() | |||
There was a problem hiding this comment.
- This appears to be unrelated to the current commit
- This should likely be a
fixcommit on its own
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
Tracking issue #14520
get_registry_candidates,get_example_candidates,get_test_candidates,get_bench_candidates,get_bin_candidates