Skip to content

Add location information in patch error messages #14473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 99 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
99 commits
Select commit Hold shift + click to select a range
f6c1d8b
chore(deps): update rust crate gix to 0.64.0
renovate[bot] Aug 1, 2024
3506d1c
chore(deps): update rust crate windows-sys to 0.59
renovate[bot] Aug 1, 2024
c8b15c4
Change tests to support `rustc` wording changes
estebank Aug 1, 2024
b5d1a27
Fix a typo in 1.81 changes
cuviper Aug 2, 2024
48849fe
docs(unstable): Link the nightly unstable page, not a specific feature
epage Aug 2, 2024
488f8dc
docs(unstable): Make the nightly link standout a bit more
epage Aug 2, 2024
9c0c0be
faq: rephrase offline usage.
soloturn Aug 1, 2024
a8b72e2
refactor(toml): Rename 'resolved' to 'normalized'
epage Aug 1, 2024
dd28870
test(build-std): expand assertion to ensure no index update
weihanglo Aug 6, 2024
0921819
fix(build-std): remove hack on creating virtual std workspace
weihanglo Aug 6, 2024
693fbf3
refactor: remove unused `Workspace::new_virtual`
weihanglo Aug 6, 2024
4aafcc5
Fix renamed disallowed cfg lint name
Urgau Aug 5, 2024
eb02367
Don't specify the depdency name in the inferred name test
dpaoliello Aug 5, 2024
bc50190
Add misbehaving tests.
jneem Aug 1, 2024
b45fe8e
Change registry inference rules when packaging multiple packages
jneem Aug 7, 2024
0e17ae1
test(vendor): Clarify what vendor config is used
epage Aug 7, 2024
cd92eb1
test(vendor): Fork the package tests
epage Aug 7, 2024
bada1dd
test(vendor): Drop explicitlu specified build-target cases
epage Aug 7, 2024
8b1434e
test(vendor): Port 'package' tests to 'vendor'
epage Aug 7, 2024
0cef0ca
fix(vendor): Strip excluded build targets
epage Aug 7, 2024
408e6b7
fix: std Cargo.lock moved to `library` dir
weihanglo Aug 8, 2024
6c4de47
test: Add test for issue-14354
linyihai Aug 6, 2024
3960473
fix: `cargo package` failed on bare commit git repo
linyihai Aug 6, 2024
5d39b08
feat: don't generate `.cargo_vcs_info.json` if git repro has no commit
linyihai Aug 7, 2024
3b21431
Use context instead of with_context
mo8it Aug 9, 2024
f1d4abf
Use `with_context` with `format!`
mo8it Aug 9, 2024
9ab3fe3
`context` directly on error instead of Err variant
mo8it Aug 9, 2024
694d77d
Remove unused import
mo8it Aug 9, 2024
7554af6
Apply suggestions from code review
mo8it Aug 9, 2024
27e8541
CI: Switch macos aarch64 to nightly
ehuss Aug 9, 2024
532e928
feat: Add `info` cargo subcommand
0xPoe Jun 25, 2024
5e4d151
test: migrate all test from cargo-information
0xPoe Jul 17, 2024
2289c5d
docs: add cargo-info subcommand and add man page
0xPoe Jul 21, 2024
f4f17e5
docs: add completions for bash and zsh
0xPoe Jul 21, 2024
5be068f
test: Add test for issue rust-lang#14379
jemtucker Aug 10, 2024
29d8346
fix: use longhand gitoxide path-spec patterns
jemtucker Aug 10, 2024
854edca
refactor: extract remap rules into functions
weihanglo Jul 31, 2024
ac699e0
test: show `trim-paths=diagnostics` doesnt works for rustdoc
weihanglo Aug 12, 2024
361832d
feat(trim-paths): rustdoc supports trim-paths for diagnostics
weihanglo Aug 9, 2024
b6c205a
chore: downgrade to openssl v1.1.1 (again)
weihanglo Aug 13, 2024
f6d4349
chore: pin also openssl crate to 0.10.57
weihanglo Aug 13, 2024
6d0090e
Fix MSRV for workspace .package and .dependencies
akonradi Aug 14, 2024
2c9083b
doc: convert comments to rustdoc in workspace
ifropc Aug 14, 2024
1009b71
Implement base paths (RFC 3529) 1/n: path dep and patch support
dpaoliello Aug 6, 2024
24a2fd2
chore: Update snapbox
epage Aug 14, 2024
db9a702
test: migrate metabuild json to snapbox
epage Aug 14, 2024
5afd1a6
test: migrate doc json to snapbox
epage Aug 14, 2024
c62e593
feat: add new lockfile-path for metadata
ifropc Jul 17, 2024
8827c0e
feat: add lockfile-path flag for all requested commands
ifropc Jul 19, 2024
87efa69
test: add extra test for package command
ifropc Jul 30, 2024
ae6d544
doc: add docs for lockfile-path
ifropc Jul 31, 2024
9d5c591
test: lockfile path test refactoring
ifropc Jul 31, 2024
1c22f85
refactoring: lockfile-path documentation and implementation cleanup
ifropc Aug 1, 2024
2656117
feat: lockfile path refactoring
ifropc Aug 3, 2024
73c0daa
refactoring: move lock_root into worspace
ifropc Aug 4, 2024
00795e5
feat lockfile-path and related tests refactoring
ifropc Aug 9, 2024
bccd5ea
lockfile path tests refactoring
ifropc Aug 14, 2024
70f144e
feat: lockfile path move create logic into write_pkg_lockfile
ifropc Aug 14, 2024
2e38bba
test: lockfile path test refactoring
ifropc Aug 16, 2024
871bdc3
Correct diagnostic for `TomlDebugInfo`
ctz Aug 16, 2024
2b45bd2
test: Migrate old_cargos to snapbox
epage Aug 15, 2024
636982d
refactor(update): Consolidate latest message rendering
epage Aug 14, 2024
6287bf0
refactor(update): Consolidate latest calculation
epage Aug 14, 2024
2fb863c
refactor(update): Extract rust-version lookup
epage Aug 14, 2024
645ac10
fix(update): Only show 'latest' messages for registry sources
epage Aug 14, 2024
9319f95
feat(update): Report when incompatible-rust-version packages are sele…
epage Aug 14, 2024
36c2e25
test: lockfile path test refactoring
ifropc Aug 17, 2024
410d221
test: lockfile path unstable feature tests
ifropc Aug 17, 2024
0875fa0
fix: remove list owners feature of info subcommand
0xPoe Aug 17, 2024
77be729
doc: update lockfile-path tracking issue
ifropc Aug 18, 2024
d9ffd18
doc: add lockfile-path unstable doc section
ifropc Aug 18, 2024
5d426fe
chore: update label trigger for Command-info
weihanglo Aug 18, 2024
8763bfb
test: add a regression test for Issue 14409
0xPoe Aug 20, 2024
57a1c08
test: add `opt_version_req_mathes_prerelease` test
linyihai Aug 16, 2024
70d07e3
fix: Limiting prerelease match semantics to use only on `OptVersionRe…
linyihai Aug 16, 2024
e77d121
Add misbehaving test for packaging unpublishable workspace
jneem Aug 15, 2024
58bc6b3
Split infer_registry into inference and validation parts.
jneem Aug 19, 2024
25ae068
Move infer_registry into a more public spot
jneem Aug 19, 2024
412a468
Use the shared source building in package
jneem Aug 19, 2024
bc71cb3
Allow unpublishable crates to be packaged
jneem Aug 19, 2024
d5e74aa
Fix issue ' cargo t --doc does not respect --color when a compilation…
ShashiSugrim Aug 18, 2024
ad6d0ae
[mdman] Add a test for a code block split across multiple lines in an…
dpaoliello Aug 19, 2024
99c2ecc
[mdman] Normalize newlines when rendering options
dpaoliello Aug 19, 2024
cdb7d09
test: show runtime-dep and build-dep collides
weihanglo Aug 20, 2024
76f1415
fix: `-Cmetadata` includes whether extra rustflags is same as host
weihanglo Aug 21, 2024
2c41b96
Tests rely on absence of RUST_BACKTRACE
kornelski Aug 21, 2024
a4d3fd0
refactor(update): Move the allocation out of PackageDiff
epage Aug 20, 2024
31c0a9a
refactor(update): Prefer Copy over references
epage Aug 20, 2024
e4664ab
fix(update): Show required rust-version in one more case
epage Aug 20, 2024
db5a036
refactor(update): Be clearer, consistent in variable name
epage Aug 20, 2024
63d4087
refactor(update): Remove unnecesary derefs
epage Aug 20, 2024
e55359b
refactor(update): Be consistent in what source we interact with
epage Aug 20, 2024
5a3265a
fix(update): Add missing required rust-version note for git
epage Aug 20, 2024
027025a
refactor(update): Centralize "what is a change"
epage Aug 20, 2024
e2f9bdb
refactor(update): Centralize status key
epage Aug 20, 2024
3394ae8
refactor(update): Centralize status style
epage Aug 20, 2024
210dfcd
refactor(update): Consolidate change rendering
epage Aug 20, 2024
e58ccfd
refactor(update): Consolidate status messages
epage Aug 21, 2024
cb1ce2e
Add location information in patch error messages
antoniospg Aug 31, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
10 changes: 5 additions & 5 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -140,17 +140,17 @@ jobs:
os: ubuntu-latest
rust: nightly
other: i686-unknown-linux-gnu
- name: macOS x86_64 stable
os: macos-13
- name: macOS aarch64 stable
os: macos-14
rust: stable
other: x86_64-apple-ios
other: x86_64-apple-darwin
- name: macOS x86_64 nightly
os: macos-13
rust: nightly
other: x86_64-apple-ios
- name: macOS aarch64 stable
- name: macOS aarch64 nightly
os: macos-14
rust: stable
rust: nightly
other: x86_64-apple-darwin
- name: Windows x86_64 MSVC stable
os: windows-latest
Expand Down
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@

- ❗️ cargo-package: Disallow `package.license-file` and `package.readme` pointing
to non-existent files during packaging.
- ❗️ cargo-package: generated `.cargo_vcs_info.json` is always incluced,
- ❗️ cargo-package: generated `.cargo_vcs_info.json` is always included,
even when `--allow-dirty` is passed.
[#13960](https://github.com/rust-lang/cargo/pull/13960)
- ❗️ Disallow passing `--release`/`--debug` flag along with the `--profile` flag.
Expand Down
Loading