Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warning suppression for config.toml vs config compat symlinks #13793

Merged
merged 5 commits into from
Apr 24, 2024
Merged

Fix warning suppression for config.toml vs config compat symlinks #13793

merged 5 commits into from
Apr 24, 2024

Commits on Apr 24, 2024

  1. Tests: Rename config symlink creation function 

    "symlink A to B" is confusing; it is ambiguous (at leaset to me)
whether it means A -> B or B -> A.

And I'm about to introduce a function that does the reverse,
and also one that makes a relative rather than full path link.

So rename this function.
    @ijackson
    ijackson committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    13be0cf View commit details
    Browse the repository at this point in the history

  2. Tests: Add test case for config -> config.toml (relative)

    @ijackson
    ijackson committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    dcce007 View commit details
    Browse the repository at this point in the history

  3. Tests: Add test case for config.toml -> config

    @ijackson
    ijackson committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    91f3e45 View commit details
    Browse the repository at this point in the history

  4. config reading: use same_file for suppressing "both files" warning 

    This is 100% reliable on Unix, and better on Windows.

(In this commit I avoid reindenting things to make review easier; the
formatting will be fixed in the next commit.)

Fixes rust-lang#13667
    @ijackson
    ijackson committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    23440c0 View commit details
    Browse the repository at this point in the history

  5. config reading: use same_file for suppressing "both files" warning (fmt) 

    Apply deferred indentation changes.  Whitespace change only.
    @ijackson
    ijackson committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    2f16838 View commit details
    Browse the repository at this point in the history