Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(resolver): Don't do git fetches when updating workspace members #12975

Merged
merged 2 commits into from
Nov 18, 2023
Merged

fix(resolver): Don't do git fetches when updating workspace members #12975

merged 2 commits into from
Nov 18, 2023

Commits on Nov 14, 2023

  1. test(update): Verify --workspace behavior 

    Looks like `--workspace` and `-p <workspace-member>` behave differently.
    @epage
    epage committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    80225bb View commit details
    Browse the repository at this point in the history

  2. fix(resolver): Don't do git fetches when updating workspace members 

    Before, when running `cargo update <member>`, we'd not reuse the
previous resolve result and when the resolver started walking into the
dependencies, it would do a git fetch.

Now, we won't even try to resolve the workspace members and so we won't
look at those dependencies and do git fetch.

This will make `cargo update <workspace-member>`
match `cargo update --workspace`.
I considered whether there were other ways of handling this but I
figured aiming for consistency in approaches was the best way.
We can investigate improving those approaches separately.

There are other discrepancies in the different code paths (handling of
patches, adding sources) but I'm deferring looking over those.

Between this and rust-lang#12602, this should finnally resolve rust-lang#12599.

Fixes rust-lang#12599
    @epage
    epage committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    9ca6376 View commit details
    Browse the repository at this point in the history