Set tracing target for networking messages.#12582
Conversation
|
r? @weihanglo (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-dependency-resolution
|
I'm not sure if we want to start using tracing targets, but I'm intrigued by the idea and I think it would be something interesting to explore. For example, to get fingerprint logging, the logs from |
|
@bors r+ This seems like a good place for us to experiment with this feature. |
bors
added
S-waiting-on-bors
weihanglo
left a comment
weihanglo
left a comment
There was a problem hiding this comment.
If a dependency is set with the same tracing target, will CARGO_LOG=network enable it also?
If this is the case, should we have a less generic target name?
|
☀️ Test successful - checks-actions |
I believe targets are a global namespace, so I think so. But if a dependency does that, presumably the message would be related to networking and we would want it included? The idea is to show everything networking-related. Also, it seems to be pretty rare that I've seen anyone use the target feature. I would be surprised if any low-level library is doing that. |
Update cargo 18 commits in 925280f028db3a322935e040719a0754703947cf..96fe1c9e1aecd8f57063e3753969bb6418fd2fd5 2023-08-25 21:16:44 +0000 to 2023-08-29 20:10:34 +0000 - fix(lints): Fail when overriding inherited lints (rust-lang/cargo#12584) - cargo install: suggest --git when package name is url (rust-lang/cargo#12575) - chore: remove unstable-options for logout (rust-lang/cargo#12588) - Improve logout message for asymmetric tokens (rust-lang/cargo#12587) - fix(update): Remove references to -p in help (rust-lang/cargo#12586) - fix(update): Make `-p` more convenient by being positional (rust-lang/cargo#12545) - Set tracing target for networking messages. (rust-lang/cargo#12582) - Retry docs (rust-lang/cargo#12583) - feat(resolver): **Very** preliminary MSRV resolver support (rust-lang/cargo#12560) - Update git2 (rust-lang/cargo#12580) - Explain how `version` works for `git` dependencies (rust-lang/cargo#12270) - Improve deserialization errors of untagged enums (rust-lang/cargo#12574) - Add support for `target.'cfg(..)'.linker` (rust-lang/cargo#12535) - Improve resolver version mismatch warning (rust-lang/cargo#12573) - Stabilize `--keep-going` (rust-lang/cargo#12568) - Define {{command}} for use in src/doc/man/includes (rust-lang/cargo#12570) - Update serde (rust-lang/cargo#12569) - chore: add missing `windows-sys` features back (rust-lang/cargo#12563) r? ghost
5 participants
This changes the log messages for messages related to network traffic to use the "network" tracing target. This makes it easier to do
CARGO_LOG=network=trace CARGO_HTTP_DEBUG=trueinstead of trying to figure out which modules to include (and to avoidCARGO_LOG=tracewhich can be too noisy). For example, #12290 moved the location of some log messages to a different module, which broke the documented workflow of usingCARGO_LOG=cargo::ops::registry=debugto get networking information.