-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update linux-raw-sys to 0.3.2 #11998
Conversation
Adds support for LoongArch.
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @weihanglo (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pull request. I hope there are more contexts for Cargo maintainers to digest in the PR description. Specifically,
- Why issue did you encounter in Cargo with LoongArch?
- Why do you think bump this would fix the issue?
- Given
loongarch64-unknown-linux-gnu
a tier-3 toolchain. AFAIK, Rust doesn't guarantee tier-3 toolchain to have stable host tools. In that regard, is this PR still relevant?
Anyway, it seems pretty straightforward and no harm for a bump. Just request for information. Thank you!
@weihanglo Thanks for your comments.
In the current version of Cargo's dependency graph, there is an indirect dependency on linux-raw-sys which does not yet have support for LoongArch.
The linux-raw-sys has been supporting LoongArch since version 0.3.2.
We are preparing to promote loongarch64-unknown-linux-gnu to Tier 2 and adding CI support based on this PR will be necessary. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sense to me. Going to merge this. If you find anything wrong, say it and we can rollback if needed.
@bors r+ |
☀️ Test successful - checks-actions |
Update cargo 14 commits in d0a4cbcee614fdb7ba66e860e603a00a644d71f8..de80432f04da61d98dcbbc1572598071718ccfd2 2023-04-16 17:42:50 +0000 to 2023-04-21 13:18:32 +0000 - Bump to 0.72.0; update changelog (rust-lang/cargo#12012) - Remove `src/doc` from `exclude` list in Cargo.toml (rust-lang/cargo#12000) - `--help` output use line wrap (rust-lang/cargo#12013) - Fix semver checks for 1.69 (rust-lang/cargo#12011) - Update contributor guide with new issue labels. (rust-lang/cargo#12003) - Better error message when getting an empty dep table (rust-lang/cargo#11997) - Fix broken links in contributor guide. (rust-lang/cargo#12002) - Update linux-raw-sys to 0.3.2 (rust-lang/cargo#11998) - chore: Use globs for workspace members (rust-lang/cargo#11996) - fix: Allow win/mac credential managers to build on all platforms (rust-lang/cargo#11993) - Add S-triage auto-label. (rust-lang/cargo#11995) - ci: check if Cargo.lock is up-to-date (rust-lang/cargo#11994) - Recompile on profile rustflags changes (rust-lang/cargo#11981) - Clarify some 1.69 changelog entries. (rust-lang/cargo#11982)
Update cargo 14 commits in d0a4cbcee614fdb7ba66e860e603a00a644d71f8..de80432f04da61d98dcbbc1572598071718ccfd2 2023-04-16 17:42:50 +0000 to 2023-04-21 13:18:32 +0000 - Bump to 0.72.0; update changelog (rust-lang/cargo#12012) - Remove `src/doc` from `exclude` list in Cargo.toml (rust-lang/cargo#12000) - `--help` output use line wrap (rust-lang/cargo#12013) - Fix semver checks for 1.69 (rust-lang/cargo#12011) - Update contributor guide with new issue labels. (rust-lang/cargo#12003) - Better error message when getting an empty dep table (rust-lang/cargo#11997) - Fix broken links in contributor guide. (rust-lang/cargo#12002) - Update linux-raw-sys to 0.3.2 (rust-lang/cargo#11998) - chore: Use globs for workspace members (rust-lang/cargo#11996) - fix: Allow win/mac credential managers to build on all platforms (rust-lang/cargo#11993) - Add S-triage auto-label. (rust-lang/cargo#11995) - ci: check if Cargo.lock is up-to-date (rust-lang/cargo#11994) - Recompile on profile rustflags changes (rust-lang/cargo#11981) - Clarify some 1.69 changelog entries. (rust-lang/cargo#11982)
ci: Add support for dist-loongarch64-linux We are preparing to promote loongarch64-unknown-linux-gnu to Tier 2, and one of the tasks is to add CI support. We are currently in the process of upgrading the dependencies for the build tools, and before this is completed, we would like to request comments. Thanks #### Progress - [x] Update linux-raw-sys to 0.3.2 (rust-lang/cargo#11998) - [x] Update openssl-src to 111.25.3+1.1.1t (rust-lang/cargo#12005) - [x] bootstrap: Update linux-raw-sys to 0.3.2 (rust-lang#110516) - [x] Update linux-raw-sys to 0.3.4 (rust-lang#110518) - [x] Update cargo (rust-lang#110834) - [x] linux_like: Add missing constants for loongarch64 (rust-lang/libc#3237) - [x] Release 0.2.143 (rust-lang/libc#3236) - [x] Update libc to 0.2.144 (rust-lang/cargo#12098) - [x] Update cargo (rust-lang#111456) Tier 2 with host tools MCP: rust-lang/compiler-team#518
ci: Add support for dist-loongarch64-linux We are preparing to promote loongarch64-unknown-linux-gnu to Tier 2, and one of the tasks is to add CI support. We are currently in the process of upgrading the dependencies for the build tools, and before this is completed, we would like to request comments. Thanks #### Progress - [x] Update linux-raw-sys to 0.3.2 (rust-lang/cargo#11998) - [x] Update openssl-src to 111.25.3+1.1.1t (rust-lang/cargo#12005) - [x] bootstrap: Update linux-raw-sys to 0.3.2 (rust-lang/rust#110516) - [x] Update linux-raw-sys to 0.3.4 (rust-lang/rust#110518) - [x] Update cargo (rust-lang/rust#110834) - [x] linux_like: Add missing constants for loongarch64 (rust-lang/libc#3237) - [x] Release 0.2.143 (rust-lang/libc#3236) - [x] Update libc to 0.2.144 (rust-lang/cargo#12098) - [x] Update cargo (rust-lang/rust#111456) Tier 2 with host tools MCP: rust-lang/compiler-team#518
Adds support for LoongArch.