`clippy --keep-going`

[kaleidawave]

Problem

I have a workspace with a few crates that internally depend on each other. If I make a change across crates (or update clippy lints) I want to see all the lint failings across the workspace.

Currently running clippy --keep-going, the --keep-going flag seems to have no effect, with it stopping at $crate1 without checking $crate2 etc

I would prefer not to merge errors into warnings and have them mix

error: could not compile $crate1 (lib) due to 3 previous errors; 47 warnings emitted.

The problem is the reason is pedantic lint clippy::redundant_closure (which is an error under our configuration) being thrown. While this is an error in our setup it should still allow compilation (could not compile should not be raised).

Proposed Solution

I do not know whether clippy discerns between compilation errors and lint errors. If clippy say returned the exit code 3 for compilation and exit code 4 for a lint error, then cargo could continue running clippy on other workspace members if the exit code is 3?

Notes

rust-lang/rust-clippy#1707 and https://users.rust-lang.org/t/keep-going-with-cargo-clippy/106020/4 sort of discuss this

[epage]

While cargo-clippy isn't maintained here, this is also affectively a request to change the rust-driver / cargo interface. Unsure where this would be best to live.

There is an unstable feature that may replace the need for this though: --warnings=deny. This directly replaces -Dwarnings but is handle. in Cargo rather than rustc/clippy. This will mean any warning that would have been turned into an error will and the compilation process will keep going.

You might instead have that clippy lint statically set to deny. Personally I recommend against it because

• being too strict when experimenting can have a major negative impact on productivity
• lints can change over time and having an upgrade stop local development can also be a big impact on productivity

What I recommend is denying lints in CI and pinning the compiler version with a version upgrade tool updating the pinned compiler on release of a new version. For example, you can see my lint CI step at https://github.com/epage/_rust/blob/7a72bd0e0dcfee16d8a59cb1c89042968e3d01f4/.github/workflows/ci.yml#L127