Skip to content

Track base branch #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 14, 2025
Merged

Track base branch #230

merged 2 commits into from
Mar 14, 2025

Conversation

Sakib25800
Copy link
Contributor

Prerequisite to #219

Copy link
Contributor

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! The core of the implementation looks solid, but I have a couple of notes/questions.

@Sakib25800
Copy link
Contributor Author

Squash and rebase?

Copy link
Contributor

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing the base branch to the PR approve/unapprove/... methods is quite annoying. I still think that it is worth it to have the base branch non-nullable though, because a PR without a base branch doesn't really make any sense.

Could you please modify the DB methods that update PRs (e.g. approve/unapprove) to receive a PullRequestModel as a parameter, instead of PR number, base branch etc.? This will both ensure that a PR that we're trying to edit exists in the DB, and also it will avoid us having to pass N parameters to all these methods once we start adding more non-NULL attributes to PRs.

@Kobzol
Copy link
Contributor

Kobzol commented Mar 14, 2025

Btw before rebasing I would advise you to squash the changes, yes :) It will make the rebase much more pleasant.

@Sakib25800
Copy link
Contributor Author

Fixed.

Looks much cleaner (using PullRequestModel as a param).

Copy link
Contributor

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Kobzol Kobzol added this pull request to the merge queue Mar 14, 2025
Merged via the queue into rust-lang:main with commit 9ace44c Mar 14, 2025
2 checks passed
@Kobzol Kobzol mentioned this pull request Mar 15, 2025
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants