-
Notifications
You must be signed in to change notification settings - Fork 30
Track base branch #230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track base branch #230
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! The core of the implementation looks solid, but I have a couple of notes/questions.
379dc5d
to
379acff
Compare
Squash and rebase? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passing the base branch to the PR approve/unapprove/... methods is quite annoying. I still think that it is worth it to have the base branch non-nullable though, because a PR without a base branch doesn't really make any sense.
Could you please modify the DB methods that update PRs (e.g. approve/unapprove) to receive a PullRequestModel
as a parameter, instead of PR number, base branch etc.? This will both ensure that a PR that we're trying to edit exists in the DB, and also it will avoid us having to pass N parameters to all these methods once we start adding more non-NULL attributes to PRs.
Btw before rebasing I would advise you to squash the changes, yes :) It will make the rebase much more pleasant. |
f73a8a7
to
d07200c
Compare
Fixed. Looks much cleaner (using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Prerequisite to #219