Tree Closing and Opening

[Rhythm1710]

Fixes: #207

[Kobzol]

Thanks for the changes. Left a few more comments.

I wonder if we should pre-fill the DB with known repositories when bors starts, because it does know the list of repositories at the beginning. Then we wouldn't have to assume everywhere in code that the repository might be missing. Although there are some edge cases around a repository being added to bors while it is running (although we will ~never hit that in practice). Anyway, that can be done in a separate PR.

[Rhythm1710]

Thanks for the changes. Left a few more comments.

I wonder if we should pre-fill the DB with known repositories when bors starts, because it does know the list of repositories at the beginning. Then we wouldn't have to assume everywhere in code that the repository might be missing. Although there are some edge cases around a repository being added to bors while it is running (although we will ~never hit that in practice). Anyway, that can be done in a separate PR.

I think that is a better approach. If you want I can add this in this PR only .

[Kobzol]

No let's keep that for the future, it's a larger change and I need to think about it more.

[Kobzol]

I rebased the PR and refactored some parts a bit. I left one TODO for you to resolve, to fill in the source of the tree closed message. It should be a URL pointing to the PR comment that closed the tree.

[Rhythm1710]

I rebased the PR and refactored some parts a bit. I left one TODO for you to resolve, to fill in the source of the tree closed message. It should be a URL pointing to the PR comment that closed the tree.

Implemented this using

Function:- source: format!( "https://github.com/{}/pull/{}", repo_state.repository(), pr.number ),

Test:-source: format!( "https://github.com/{}/pull/{}", default_repo_name(), default_pr_number() ),

[Kobzol]

We want to have a link to the specific comment that closed the tree, not just the PR, that could have a lot of comments (we want to see the reason why the tree was closed).
The issue_comment webhook contains a property comment.html_url, which contains a HTML URL link to the comment. It should be parsed from the webhook and stored in the parsed pull request.

We can then use that as the tree closed source.

[Kobzol]

Thank you!