feat: add github client dedicated for ci #186
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Oh, crap, that is unfortunate. I'll discuss this with the infra team. |
Is that still the case? Based on github/roadmap#330 and https://github.blog/changelog/2022-06-27-improved-innersource-collaboration-and-enterprise-fork-policies/ I would have assumed this is now possible. |
Contributor
Author
|
I'm not sure. Need someone with admin permission in rust-lang org to test this 😅 |
Member
|
As per #182 (comment), we shouldn't need this anymore. Thank you for working on this though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR adds a new github client to interact with CI repo.
Why
The CI repo for Rust belongs to a different organization than the original repo, since we can't create a fork of a repo inside the same organization. However, Github doesn't support cross-orgs operations with Github App. We have to use another mechanism to authenticate with the CI repo.
How
This PR introduces a new Github client, authenticated with Personal Access Token. This is the same method used by homu (ref)