Skip to content

Conversation

@GamerPear
Copy link

Line 113 changed from "beyond the range of the vector may happen..." to "beyond the range of the vector, which may happen..."

Line 113 changed from "beyond the range of the vector may happen..." to "beyond the range of the vector, which may happen..."
@0xYonJuuNi
Copy link

Not a native speaker but this seems fine to me. Try reading the sentence by leaving out some parts.
"(You would use this method if) accessing an element
(beyond the range of the vector) may happen occasionally under normal
circumstances."

@GamerPear
Copy link
Author

"You would use this method if accessing an element beyond the range of the vector," is a good, valid sentence and so is "Accessing an element beyond the range of the vector may happen occasionally under normal circumstances."

They both have the same idea of "accessing an element beyond the range of the vector", but are telling us two different things about it. The first sentence tells us that we should use "this method" when when we do it, while the second sentence tell us that doing it "may happen occasionally."

I don't remember the proper terminology for sentence composition, but since they have two separate subjects (first sentence's is us, while the second sentence's is "accessing an element ... vector") they can't be in a simple sentence and they have to be conjoined in some way. There are other ways to rewrite it than the way I did, but I just did the simplest change to make it correct.

@anthonysharpy
Copy link

I think the use of may in the original sentence makes it sound quite confusing, so I think OP is correct to point it out

You would use this method if accessing an element beyond the range of the vector may happen occasionally under normal circumstances.

I think the more natural version would be:

You would use this method if accessing an element beyond the range of the vector might happen occasionally under normal circumstances.

Or, more succinctly, maybe something like:

You would use this method if you might try to access an element beyond the range of the vector.

The use of which implies a value judgement which I don't think was intended in the original

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants