Add more words to the quote from the actual Go documentation #1960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ally has an opposite meaning
|
It seems merging was blocked. :( |
JaewooKim0
suggested changes
Jun 28, 2019
There was a problem hiding this comment.
Ah, sorry for my previous wrong suggestion. It would be better just quote "do not communicate by sharing memory" part.
I tried to delete my suggestion, but I couldn't find a way to do it. Then, I hopelessly :) tried to approve the original request. But cause I don't have write access, my approving review would be ignored.
JaewooKim0
approved these changes
Jun 28, 2019
steveklabnik
approved these changes
Sep 15, 2019
Contributor
steveklabnik
left a comment
steveklabnik
left a comment
There was a problem hiding this comment.
Yes, this is an embarrassing mistake on our part, thanks so much!
tmandry
added a commit
to tmandry/rust
that referenced
this pull request
Sep 18, 2019
Update books ## book 24 commits in 7ddc46460f09a5cd9bd2a620565bdc20b3315ea9..871416b85c1a73717d65d6f4a9ea29e5aef3db0e 2019-06-27 09:50:36 -0400 to 2019-09-16 09:46:20 -0400 - Ch16-2 add missing Ferris (rust-lang/book#2033) - Update version mentioned on the front page - Update error messages (rust-lang/book#1737) - Update version of Rust used to 1.37 - Replace Cargo docs link with a more specific link (rust-lang/book#2066) - Added missing await reserved keyword (rust-lang/book#2064) - add does_not_compile for a snippet (rust-lang/book#2056) - Added second missing dyn (rust-lang/book#2046) - Removed unnecessary & in function call (rust-lang/book#2038) - Printing non-Display structs is a *compile* error (rust-lang/book#2031) - Update Readme mdBook version to match linked file (rust-lang/book#2012) - Update loose mdbook version reference (rust-lang/book#2003) - Added a bullet point to have list of things unsafe allows for match u… (rust-lang/book#1993) - Rewrote a confusing sentence (rust-lang/book#1986) - Replace deprecated `...` range syntax with `..=` (rust-lang/book#1977) - correct wording for integration test doc (rust-lang/book#1971) - Mark the dangle function as does_not_compile (rust-lang/book#1965) - Add more words to the quote from the actual Go documentation (rust-lang/book#1960) - Remove unused import in lfp (rust-lang/book#1944) - A small typo? (rust-lang/book#1931) - Make the code not compile to match the text (rust-lang/book#1926) - Ferris does-not-compile added (ch9.2) (rust-lang/book#1925) - ch07 - remove note regarding use and relative path (rust-lang/book#1820) - tweak opening paragraph of deref coercions (rust-lang/book#1749) ## rust-by-example 9 commits in e76be6b2dc84c6a992e186157efe29d625e29b94..67cfbf31df880728dcf7cb35b15b028ec92caf31 2019-09-03 07:42:26 -0300 to 2019-09-18 09:36:40 -0300 - Fix rust-lang/rust-by-example#90: Add supertraits and Fully Qualified syntax (rust-lang/rust-by-example#1259) - Fix some broken links. (rust-lang/rust-by-example#1258) - Fix rust-lang/rust-by-example#1253: Document enum type aliases (rust-lang/rust-by-example#1255) - Inline code in some new/changed chapters (rust-lang/rust-by-example#1254) - fix rust-lang/rust-by-example#1067: explain that unit tests can return Result<()> (rust-lang/rust-by-example#1252) - Fix rust-lang/rust-by-example#1060: add page on Impl Trait (rust-lang/rust-by-example#1251) - Fix rust-lang/rust-by-example#1053: Added a page about the dyn keyword (rust-lang/rust-by-example#1249) - Fix rust-lang/rust-by-example#1110: add examples of ? and Option (rust-lang/rust-by-example#1250) - fix 1037: add the TryFrom chapter back in (rust-lang/rust-by-example#1247)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full quote from Go docs is: "Do not communicate by sharing memory; instead, share memory by communicating.".
The part of the quote in the current book, while quoted correctly, does indicate the opposite meaning of what Go philiosophy wanted to convey.
So the simplest fix is to extend the quotation to return back the original meaning.