Skip to content

Incorrect field name in chapter 13 #3399

Closed
@infinityfye

Description

@infinityfye
  • I have checked the latest main branch to see if this has already been fixed
  • I have searched existing issues and pull requests for duplicates

URL to the section(s) of the book with this problem:

Description of the problem:
This concerns the IO project from chapter 12 and the improvements applied in chapter 13.
The typo specifically is filename as opposed to file_path when referring to the Config struct field and when referring to the variable in Config::build
In line 31 it is stated that the Config struct field is filename while it is file_path. While in line 121 it is stated that the value is filename while it should be file_path

Suggested fix:
Change both occurrences of filename to file_path.
I would have opened a PR directly, but there is another solution that wouldn't cause a difference with the printed version; to change the linked code in the Config struct definition and in Config::build. This will break compatibility with chapter12, but it's still a viable solution, I think.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions