Match colours with main website #533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How would it work if we removed the background completly? |
|
This is just a colour swap, this would obviously need spacing changes as well, but I'm not fan of it. Mainly I think because I don't like Fira Sans as a font enough to think it can stand alone. Maybe if we had a different font and maybe other elements it could work. Current / White
Fira Sans / System Default (San Francisco on macOS)
|
Manishearth
approved these changes
Mar 4, 2020
|
@pietroalbini Do you approve of the new gray for the blog feed background? |
|
Yeah, the new grey is fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the colours on the blog to match the new colours on the website. I'm also proposing changing from using the background colour for the posts feed to gray, as I feel that works better with the post list than the purple (though I don't mind the the purple). I've put in a comparison screenshots below.
Old / New Purple
Old Purple / New Gray
New Purple / New Gray