Skip to content

CI: fix fetch of PR fork commits in binary size check workflow #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2023
Merged

CI: fix fetch of PR fork commits in binary size check workflow #544

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/check-binary-size.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
run: |
printf "[llvm]\ndownload-ci-llvm = true\n\n[rust]\nincremental = false\n" > config.toml
cd library/backtrace
git remote add kobzol https://github.com/kobzol/backtrace-rs
git remote add head-pr https://github.com/${{ github.event.pull_request.head.repo.full_name }}
Copy link
Member

@workingjubilee workingjubilee Jul 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...Impressive. I don't know why I missed this.

git fetch --all
git checkout ${{ github.event.pull_request.base.sha }}
cd ../..
Expand Down