Skip to content

Fix error chapter with regards to deprecated description() and cause() #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 5, 2020
Merged

Fix error chapter with regards to deprecated description() and cause() #209

merged 2 commits into from
Jan 5, 2020

Conversation

@faern
Copy link
Contributor

@faern faern commented Jan 5, 2020

  • The error chapter still mentions cause() but not source() - Fixed
  • The error chapter says users should use Display instead of description() but it still encourages implementing it. That method is now fully deprecated (nightly) and should not be implemented at all for new errors.

dtolnay
dtolnay approved these changes Jan 5, 2020
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dtolnay dtolnay merged commit 1e3d0f9 into rust-lang:master Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@faern @dtolnay