Skip to content

Conversation

KodrAus
Copy link
Contributor

@KodrAus KodrAus commented Aug 4, 2018

Including #103 which fixes a soundness issue with public fields and introduces a build script to automatically select an appropriate implementation based on the available compiler.

I went for the conservative versioning approach of 1.1.0 instead of 1.0.3 since the implementation of lazy_static may change, but if anyone would prefer a patch I'll update it.

@KodrAus KodrAus requested a review from dtolnay August 4, 2018 00:00
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although I would prefer landing #113 first. This PR is a big jump in compile time over 1.0.2 which compiled in 0.1 seconds.

@dtolnay
Copy link
Member

dtolnay commented Aug 5, 2018

Rebased onto #113.

@dtolnay dtolnay merged commit 19b57ec into master Aug 5, 2018
@dtolnay dtolnay deleted the cargo/1.1.0 branch August 5, 2018 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants