This repository was archived by the owner on Nov 21, 2018. It is now read-only.
Fix TLS incompatibility by building gcc after openssl #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new certificate for ftp.gnu.org doesn't validate on centos:5 because it thinks the hostname is alpha.gnu.org, which isn't listed on the cert. Work around by dropping TLS protection on the download, relying on just the checksum for validation. Once we've bootstrapped our own openssl and curl we can download things properly, so another fix would be to move gcc later in the build order.
Building openssl and curl first lets us use TLS for all later downloads. The curl/openssl included with our Centos:5 base has compatibility problems with many modern websites. This slows the cycle time since we update openssl and curl more often than gcc, which was previously first since it's one of the slowest packages to build.
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
Sounds good to me! (note that we'll likely stop using this image soon) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to my build-order question in #151.
Previously we keep gcc at the head of the chain to reduce cycle times working on the container. Asking @alexcrichton again if we can change that.