This repository was archived by the owner on Aug 16, 2021. It is now read-only.
Use Error::description only for rust below 1.42 #285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnderEnder
force-pushed
the
conditional-macro-error-description
branch
from
fd24f31 to
6ff71d8
Compare
|
I'm a fan of this approach. |
Comment on lines
+79
to
+84
| #[doc(hidden)] | ||
| #[cfg(not(has_error_description_deprecated))] | ||
| #[macro_export(local_inner_macros)] | ||
| macro_rules! call_to_deprecated_description { | ||
| ($e:ident) => { ::std::error::Error::description($e) }; | ||
| } |
There was a problem hiding this comment.
Doesn't this need a doc comment, too? Wouldn't #![deny(missing_documentation)] trigger in case not(has_error_description_deprecated)?
There was a problem hiding this comment.
That's why CI fails.
There was a problem hiding this comment.
Tested, it fails and reverted it back
AnderEnder
force-pushed
the
conditional-macro-error-description
branch
from
6ff71d8 to
11dd09a
Compare
AnderEnder
force-pushed
the
conditional-macro-error-description
branch
from
11dd09a to
c1018b6
Compare
AndyGauge
approved these changes
Jan 10, 2020
|
Any chance of a release containing this fix? Thanks |
|
Yeah, give me a week or two, but I will release it. |
|
@AndyGauge Ping regarding release. People start noticing this on stable (#286). Thanks! :) |
|
shoot you are right, I'm behind on this. Tomorrow. |
|
🎉 0.12.2 is on crates.io Let me know if it breaks production 😉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error::descriptionhas been documented as soft-deprecated since 1.27.0 (17 months ago). It is going to be hard-deprecated soon (1.42)This PR:
has_error_description_deprecatedimpl_error_chain_kindwithout usage ofError::descriptionRelated PR: rust-lang/rust#66919
Alternative PR(with removed description): #283