Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to edition 2021 #967

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Migrate to edition 2021 #967

wants to merge 6 commits into from

Commits on Jul 4, 2024

  1. Migrate to edition 2021 

    Edition 2021 requires rustc 1.56+ so it's possible.
1. `cargo fix --edition`
2. Field "edition" updated in "Cargo.toml".
    @Philippe-Cholet
    Philippe-Cholet committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    df6a5c9 View commit details
    Browse the repository at this point in the history

  2. Automate MSRV change in the crate doc 

    I noted some months ago that the environment variable CARGO_PKG_RUST_VERSION was publicized in 1.63.0 and that if we do not go back before 1.63 then we can automate the MSRV there.
Remain "ci.yml" but I don't see a way to automate it, even with `cargo metadata --no-deps --format-version=1 | jq -r '.packages[0].version'`.
    @Philippe-Cholet
    Philippe-Cholet committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    2711f1d View commit details
    Browse the repository at this point in the history

  3. Use bool::then_some

    @Philippe-Cholet
    Philippe-Cholet committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    ca8a8fb View commit details
    Browse the repository at this point in the history

  4. Simplifications from clippy 

    `clippy::uninlined_format_args` and 2 more.
    @Philippe-Cholet
    Philippe-Cholet committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    df00c92 View commit details
    Browse the repository at this point in the history

  5. ControlFlow instead of Result

    @Philippe-Cholet
    Philippe-Cholet committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    c9d0aef View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. Drop use of deprecated form "default_features" 

    This commit fixes the following "warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition (in the `quickcheck` dependency)".
It's quite off-topic but I don't wish to make another PR to change a single character.
    @Philippe-Cholet
    Philippe-Cholet committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    8181f3f View commit details
    Browse the repository at this point in the history