Allow custom collections for multi cartesian product items #345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow `MultiProduct` to yield collections other than `Vec`. The main value is that callers can specify non-allocating types, meaning that iteration over a multi-cartesian product can be non-allocating. Creating the product itself is still an allocation, however. To not be a breaking change, the `multi_cartesian_product` method still returns a product iterating over `Vec` (since method generics can not specify defaults), and a new generic method `multi_cartesian_product_with` is added.
aschampion
force-pushed
the
features/custom-mcp-collections
branch
from
29a7bbd to
db54f58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
MultiProductto yield collections other thanVec. The mainvalue is that callers can specify non-allocating types like
SmallVec, meaning thatiteration over a multi-cartesian product can be non-allocating. Creating
the product itself is still an allocation, however.
To not be a breaking change, the
multi_cartesian_productmethod stillreturns a product iterating over
Vec(since method generics can notspecify defaults), and a new generic method
multi_cartesian_product_withis added (test withVecDequeincluded).I'm open to suggestions for a better name for the new method.
As expected, there's no performance regression from
master:This PR: