Add support to DecodeWithMemTracking #315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorpaas
reviewed
May 14, 2025
RomarQ
reviewed
May 19, 2025
| @@ -10,15 +10,15 @@ edition = "2018" | |||
|
|
|||
| [dependencies] | |||
| auto_impl = "1.0" | |||
| ethereum = { git = "https://github.com/rust-ethereum/ethereum.git", rev = "3be0d8fd4c2ad1ba216b69ef65b9382612efc8ba", default-features = false } | |||
| ethereum = { git = "https://github.com/rust-ethereum/ethereum.git", rev = "bbb544622208ef6e9890a2dbc224248f6dd13318", default-features = false } | |||
There was a problem hiding this comment.
@sorpaas could we have a new release for this package?
There was a problem hiding this comment.
@RomarQ could we merge it without the release?
There was a problem hiding this comment.
Yes, it seems fine.
cc: @sorpaas @boundless-forest @koushiro
If you guys agree, we should be able to merge this.
RomarQ
reviewed
May 19, 2025
RomarQ
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support to
DecodeWithMemTrackingthat is required to upgrade another dependencies that depends on this one to polkadotstable2503Also upgrade ethereum to include my latest commit
Similar to what I did with rust-ethereum/ethereum#62