-
Notifications
You must be signed in to change notification settings - Fork 156
move hidden into module #736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cc @rust-embedded/tools |
v0.29: https://docs.rs/rp2040-pac/latest/rp2040_pac/ This patch: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I slightly changed the wording, and put the methods all on one line.
@thejpster |
Can we remove the '\n' between the lines? If they have '\n' between them I think they should be a bulleted list. Otherwise I think it should be one paragraph with no new-lines in it. i.e.
rather than
I also propose expanding on See API a little bit. But these are minor things really. I really like these changes! |
done |
LGTM. Ship it. |
So good I managed to approve it twice :/ |
No description provided.