Skip to content

move hidden into module #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 9, 2023
Merged

move hidden into module #736

merged 2 commits into from
Aug 9, 2023

Conversation

burrbull
Copy link
Member

No description provided.

@burrbull burrbull requested a review from a team as a code owner June 14, 2023 14:48
@burrbull
Copy link
Member Author

burrbull commented Aug 4, 2023

cc @rust-embedded/tools

@thejpster
Copy link
Contributor

v0.29: https://docs.rs/rp2040-pac/latest/rp2040_pac/

image

This patch:

image

@thejpster
Copy link
Contributor

thejpster commented Aug 4, 2023

I like these changes. But I wonder if there's also scope to try and add some information to this page:

image

Edit:

Perhaps like:

image

Copy link
Contributor

@thejpster thejpster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I slightly changed the wording, and put the methods all on one line.

@burrbull
Copy link
Member Author

burrbull commented Aug 6, 2023

@thejpster
Now it looks like
изображение
and
изображение
accordingly.

@thejpster
Copy link
Contributor

Can we remove the '\n' between the lines? If they have '\n' between them I think they should be a bulleted list. Otherwise I think it should be one paragraph with no new-lines in it.

i.e.

You can read this register and get somemod::R. You can reset, write, write_with_zero this register and get somemod::W. You can also modify this register.

rather than

You can read this register and get somemod::R.
You can reset, write, write_with_zero this register and get somemod::W. 
You can also modify this register.

I also propose expanding on See API a little bit.

But these are minor things really. I really like these changes!

@burrbull
Copy link
Member Author

burrbull commented Aug 6, 2023

done

@thejpster
Copy link
Contributor

LGTM. Ship it.

@thejpster thejpster added this pull request to the merge queue Aug 9, 2023
@thejpster
Copy link
Contributor

So good I managed to approve it twice :/

Merged via the queue into master with commit f1f28e9 Aug 9, 2023
@thejpster thejpster deleted the convert branch August 9, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants