Skip to content

FieldSpec #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2023
Merged

FieldSpec #722

merged 1 commit into from
Jun 4, 2023

Conversation

burrbull
Copy link
Member

No description provided.

@burrbull burrbull marked this pull request as ready for review May 29, 2023 17:38
@burrbull burrbull requested a review from a team as a code owner May 29, 2023 17:38
@burrbull burrbull mentioned this pull request May 29, 2023
Merged
@burrbull
Copy link
Member Author

@Emilgardis What do you think about this?

Emilgardis
Emilgardis reviewed May 29, 2023
View reviewed changes
@burrbull
Copy link
Member Author

burrbull commented Jun 4, 2023

@Emilgardis So what your judgment?

Emilgardis
Emilgardis previously approved these changes Jun 4, 2023
View reviewed changes
Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, no concerns from me except maybe the name choice of Ux, but we're already using that so it's fine.

feel free to r=me

@burrbull
Copy link
Member Author

burrbull commented Jun 4, 2023

bors r=@Emilgardis

bors bot added a commit that referenced this pull request Jun 4, 2023
@bors @burrbull
Merge #722
e816587 
722: FieldSpec r=Emilgardis a=burrbull



Co-authored-by: Andrey Zgarbul <zgarbul.andrey@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jun 4, 2023

Build failed:

@burrbull
Copy link
Member Author

burrbull commented Jun 4, 2023

bors retry

bors bot added a commit that referenced this pull request Jun 4, 2023
@bors @burrbull
Merge #722
5bc8c34 
722: FieldSpec r=Emilgardis a=burrbull



Co-authored-by: Andrey Zgarbul <zgarbul.andrey@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jun 4, 2023

Build failed:

@burrbull
Copy link
Member Author

burrbull commented Jun 4, 2023

bors r=@Emilgardis

bors bot added a commit that referenced this pull request Jun 4, 2023
@bors @burrbull
Merge #722
abda487 
722: FieldSpec r=Emilgardis a=burrbull



Co-authored-by: Andrey Zgarbul <zgarbul.andrey@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jun 4, 2023

Build failed:

@Emilgardis
Copy link
Member

bors retry

@bors
Copy link
Contributor

bors bot commented Jun 4, 2023

Merge conflict.

@Emilgardis Emilgardis enabled auto-merge June 4, 2023 19:01
@Emilgardis Emilgardis added this pull request to the merge queue Jun 4, 2023
Merged via the queue into master with commit 535aac3 Jun 4, 2023
@Emilgardis Emilgardis deleted the field-spec branch June 4, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emilgardis Emilgardis Emilgardis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@burrbull @Emilgardis