Skip to content

cows, cows everywhere #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 19, 2023
Merged

cows, cows everywhere #715

merged 2 commits into from
Mar 19, 2023

Conversation

burrbull
Copy link
Member

No description provided.

@burrbull burrbull requested a review from a team as a code owner March 18, 2023 11:00
@burrbull burrbull marked this pull request as draft March 18, 2023 11:30
@burrbull
Copy link
Member Author

burrbull commented Mar 18, 2023 •
edited
Loading

Hm. Looks like "Inflect::to_snake_case" =/= "convert_case::Case::Snake"

    let string = "_1P8_READY";
    assert_eq!(string.to_snake_case(), string.to_case(Case::Snake));
thread 'main' panicked at 'assertion failed: `(left == right)`
  left: `"_1p8_ready"`,
 right: `"1_p_8_ready"`', src/main.rs:6:5

@burrbull burrbull marked this pull request as ready for review March 18, 2023 12:55
Emilgardis
Emilgardis requested changes Mar 18, 2023
View reviewed changes
ci/svd2rust-regress/src/main.rs Outdated
list: bool,

/// Path to an `rustfmt` binary, relative or absolute.
/// Defaults to `$(rustup which rustfmt)`
#[structopt(long = "rustfmt_bin_path", parse(from_os_str))]
#[clap(long = "rustfmt_bin_path")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#[clap(long = "rustfmt_bin_path")]
#[clap(long)]

svd2rust used, with structopt, snake case

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the flag should be --rustfmt-bin-path not --rustfmt_bin_path

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, rebased

Emilgardis
Emilgardis approved these changes Mar 19, 2023
View reviewed changes
Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 19, 2023

Build succeeded:

@bors bors bot merged commit d1ddb1b into master Mar 19, 2023
@bors bors bot deleted the case branch March 19, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emilgardis Emilgardis Emilgardis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@burrbull @Emilgardis