Skip to content

array accessors #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 15, 2022
Merged

array accessors #579

merged 2 commits into from
Mar 15, 2022

Conversation

burrbull
Copy link
Member

@burrbull burrbull commented Feb 2, 2022

Closes #578

@burrbull burrbull requested a review from a team as a code owner February 2, 2022 15:02
@rust-highfive
Copy link

r? @reitermarkus

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools labels Feb 2, 2022
@burrbull
Copy link
Member Author

burrbull commented Feb 2, 2022

r? @adamgreig

@burrbull burrbull force-pushed the arrays branch 2 times, most recently from 5830ff3 to c70222b Compare February 3, 2022 03:30
@burrbull
Copy link
Member Author

@adamgreig @therealprof ping

therealprof
therealprof reviewed Feb 21, 2022
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, don't have time to review with the required care at the moment.

@Emilgardis
Copy link
Member

I can't get this to work, do you have an example svd to demonstrate with?

@burrbull
Copy link
Member Author

I can't get this to work, do you have an example svd to demonstrate with?

Any SVD from https://stm32-rs.github.io/stm32-rs/

Emilgardis
Emilgardis previously approved these changes Mar 15, 2022
View reviewed changes
Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Mar 15, 2022
@bors @burrbull
Merge #579
4850a80 
579: array accessors r=Emilgardis a=burrbull

Closes #578 

Co-authored-by: Andrey Zgarbul <zgarbul.andrey@gmail.com>
@bors
Copy link
Contributor

bors bot commented Mar 15, 2022

Build failed:

@Emilgardis
Copy link
Member

SiliconLabs svds has moved to subfolders

https://github.com/posborne/cmsis-svd/blob/master/data/SiliconLabs/SiM3_NRND/SIM3C1x4.svd for example

@burrbull
Copy link
Member Author

SiliconLabs svds has moved to subfolders

https://github.com/posborne/cmsis-svd/blob/master/data/SiliconLabs/SiM3_NRND/SIM3C1x4.svd for example

Yes. And I don't see how to better fix this.

Emilgardis
Emilgardis reviewed Mar 15, 2022
View reviewed changes
Emilgardis
Emilgardis previously approved these changes Mar 15, 2022
View reviewed changes
Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Mar 15, 2022
@bors @burrbull
Merge #579
26f645f 
579: array accessors r=Emilgardis a=burrbull

Closes #578 

Co-authored-by: Andrey Zgarbul <zgarbul.andrey@gmail.com>
@bors
Copy link
Contributor

bors bot commented Mar 15, 2022

Canceled.

Emilgardis
Emilgardis approved these changes Mar 15, 2022
View reviewed changes
Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 15, 2022

Build succeeded:

@bors bors bot merged commit 7264731 into master Mar 15, 2022
@bors bors bot deleted the arrays branch March 15, 2022 21:14
@burrbull burrbull mentioned this pull request Jul 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therealprof therealprof therealprof left review comments

@Emilgardis Emilgardis Emilgardis approved these changes

Assignees

@adamgreig adamgreig

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Array access proposal
6 participants
@burrbull @rust-highfive @Emilgardis @therealprof @adamgreig @reitermarkus