Skip to content

disable the interrupt macro for MIPS as well #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2022

Conversation

kiffie
Copy link
Contributor

@kiffie kiffie commented Jan 17, 2022

r? @burrbull

Yet another small MIPS fix in addition to yesterday's change. Sorry for submitting two separate PR instead of a single one. I did not realize that the interrupt macro can cause name clashes when including multiple device support modules into a single crate. I discovered this problem when trying to build the docs.

@kiffie kiffie requested a review from a team as a code owner January 17, 2022 17:43
@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools labels Jan 17, 2022
@burrbull
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Jan 17, 2022
574: disable the interrupt macro for MIPS as well r=burrbull a=kiffie

r? `@burrbull`

Yet another small MIPS fix in addition to yesterday's change. Sorry for submitting two separate PR instead of a single one. I did not realize that the interrupt macro can cause name clashes when including multiple device support modules into a single crate. I discovered this problem when trying to build the docs.

Co-authored-by: Stephan <kiffie@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Jan 17, 2022

Build failed:

@kiffie
Copy link
Contributor Author

kiffie commented Jan 17, 2022

It seems that something in the CI job went wrong when downloading https://raw.githubusercontent.com/posborne/cmsis-svd/master/data/Fujitsu/MB9AF1AxL.svd via curl. Can it be re-triggered?

@kiffie kiffie marked this pull request as draft January 17, 2022 19:04
@kiffie kiffie marked this pull request as ready for review January 17, 2022 19:07
@burrbull
Copy link
Member

bors retry

@bors
Copy link
Contributor

bors bot commented Jan 17, 2022

Build succeeded:

@bors bors bot merged commit f7d01bd into rust-embedded:master Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants