Skip to content

don't cast if not use_mask #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).

### Fixed

- Don't cast if field same type as register
- Parenthesizing `#offset_calc` to avoid clippy's warning of operator precedence
- Replace suffix in fields' name before converting to snake case when generating methods #563

Expand Down
6 changes: 3 additions & 3 deletions src/generate/register.rs
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,7 @@ pub fn fields(
}
} else {
quote! {
self.bits #cast
self.bits
}
};

Expand Down Expand Up @@ -436,7 +436,7 @@ pub fn fields(
}
} else {
quote! {
self.bits #cast
self.bits
}
};
let name_sc_n = Ident::new(
Expand Down Expand Up @@ -720,7 +720,7 @@ pub fn fields(
let op = if use_mask {
quote!{ self.w.bits = (self.w.bits & !#hexmask) | (value as #rty & #hexmask); }
} else {
quote!{ self.w.bits = value as #rty; }
quote!{ self.w.bits = value; }
};

quote! {
Expand Down