Skip to content

offset_calc fix parenthesizing #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2022
Merged

offset_calc fix parenthesizing #568

merged 1 commit into from
Jan 15, 2022

Conversation

burrbull
Copy link
Member

@burrbull burrbull commented Jan 13, 2022 •
edited
Loading

Closes #567

@burrbull burrbull requested a review from a team as a code owner January 13, 2022 07:39
@burrbull burrbull mentioned this pull request Jan 13, 2022
Closed
@burrbull
Copy link
Member Author

No description provided.

@burrbull burrbull closed this Jan 13, 2022
@burrbull burrbull reopened this Jan 13, 2022
@burrbull
Copy link
Member Author

cc @rust-embedded/tools

adamgreig
adamgreig approved these changes Jan 15, 2022
View reviewed changes
Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 15, 2022

Build succeeded:

@bors bors bot merged commit f11cddd into master Jan 15, 2022
@bors bors bot deleted the calculate_offset branch January 15, 2022 17:32
@burrbull burrbull mentioned this pull request Jan 15, 2022
Merged
bors bot added a commit that referenced this pull request Jan 15, 2022
@bors @burrbull
Merge #569
3f06e12 
569: refix calculate offset r=adamgreig a=burrbull

#568 

Co-authored-by: Andrey Zgarbul <zgarbul.andrey@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamgreig adamgreig adamgreig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clippy warning of operator precedence when generating self.bits >> #offset_calc
2 participants
@burrbull @adamgreig