feat: Add keep_list arg to allow not to generate arrays #562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ryankurte (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
S-waiting-on-review
duskmoon314
force-pushed
the
keep-list
branch
from
ec57af9 to
1051c91
Compare
|
Need to check how it interact with #354 when |
duskmoon314
force-pushed
the
keep-list
branch
from
1051c91 to
a6cc268
Compare
|
Rebase, please. And rustfmt |
Use `[%s]` to create arrays and use `%s` to create lists ref: https://www.keil.com/pack/doc/CMSIS/SVD/html/elem_special.html
duskmoon314
force-pushed
the
keep-list
branch
from
a6cc268 to
619d2d0
Compare
rebase and fmt done |
burrbull
approved these changes
Jan 17, 2022
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New feature
Add a
keep_listarg to allow not to generate arrays.svd2rust --help # --keep_list Keep lists when generating code of dimElement, instead of trying to generate arrays svd2rust --target riscv --keep_list -i soc.svdUse
[%s]to create arrays and use%sto create listsref: https://www.keil.com/pack/doc/CMSIS/SVD/html/elem_special.html
Motivation
Issue #561
Might be useful if someone needs lists.