Skip to content

Fixes in multi line description generation #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2021
Merged

Fixes in multi line description generation #553

merged 1 commit into from
Nov 14, 2021

Conversation

luojia65
Copy link
Contributor

@luojia65 luojia65 commented Nov 14, 2021

This pull request contains two fixes:

  1. New line separators are now rendered in enumerated values.
  2. Multi line field descriptions are now rendered correctly in write and read registers.

This issue happened because the original code accidentally unescaped and respaced twice in field parse proccess. It uses escaped description L292 as input, but in desctiption_with_bits function later L1001 it unescaped again, resulting in loss of new line separators \n.

Before:

图片

After:

图片

@luojia65 luojia65 requested a review from a team as a code owner November 14, 2021 05:49
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Emilgardis (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools labels Nov 14, 2021
@burrbull
Copy link
Member

LGTM. Update changelog, please.

@luojia65
Copy link
Contributor Author

@burrbull Thanks for noting! I have updated changelog just now.

burrbull
burrbull previously approved these changes Nov 14, 2021
@luojia65
Copy link
Contributor Author

luojia65 commented Nov 14, 2021

The CI check failed just now for code format, I used cargo fmt and committed again. @burrbull I am sorry but would you mind approve these changes again?

@burrbull
Copy link
Member

squash commits, pls

@luojia65
Copy link
Contributor Author

Squashed into 1 commit

@burrbull
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 14, 2021

Build succeeded:

@bors bors bot merged commit 877196f into rust-embedded:master Nov 14, 2021
@luojia65 luojia65 deleted the fix-new-line branch May 20, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants