Skip to content

Added debug and trace output #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2021

Conversation

robamu
Copy link
Contributor

@robamu robamu commented Nov 9, 2021

The application already has log levels and these additional logs will be disabled by default. They can be helpful when debugging something or tracing where an error/warning happens

@robamu robamu requested a review from a team as a code owner November 9, 2021 13:31
@rust-highfive
Copy link

r? @reitermarkus

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools labels Nov 9, 2021
@robamu robamu force-pushed the mueller/added-trace-output branch from ef5aa6d to 7dbe137 Compare November 9, 2021 13:37
Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Output:
image

I think this helps a bit, thank you!

bors r+

let mut mod_items = TokenStream::new();
mod_items.extend(register_or_cluster_block(&ercs, &defaults, None, config)?);

debug!("Pushing cluster information into output");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

always printing this even when there's no output is a bit strange, but maybe that's a good thing.

@bors
Copy link
Contributor

bors bot commented Nov 9, 2021

Build succeeded:

@bors bors bot merged commit 17bef09 into rust-embedded:master Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants