-
Notifications
You must be signed in to change notification settings - Fork 156
svd-parser 0.11 #542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
svd-parser 0.11 #542
Conversation
r? @Emilgardis (rust-highfive has picked a reviewer for you, use r? to override) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we try using --const-generics
and --strict
on everything as option in the feature matrix? Would increase CI but I think it's worth it
Not all SVDs feel good with |
Ill get to it later today CET |
Maybe just removing the bash script and completely use svd2rust-regress is a good thing to do as well. Not sure if that would be in the scope of this pr though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, looks good to me.
needs to be changed, I'm not sure if we have a policy on how to gather multiple results and gate bors on it, but I'd prefer to have a workflow that |
This comment has been minimized.
This comment has been minimized.
for clarity, the try run shouldn't fail because of esp-rs/esp32#47 recently being merged |
ugh, changelog check is not ran on trying 🤷 |
also merges CI to one status check
bors try testing the combined ci check |
tryBuild succeeded: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
leaving bors r=me for @burrbull, not sure if this is considered done, but looks to be to me
bors r=Emilgardis |
Build succeeded: |
No description provided.