Skip to content

Xtensa updates #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 16, 2021
Merged

Xtensa updates #536

merged 2 commits into from
Aug 16, 2021

Conversation

MabezDev
Copy link
Member

  • Switch to bare-metal 1.0.0
  • Use xtensa-lx InterruptNumber trait
  • Update CI script

@MabezDev MabezDev requested a review from a team as a code owner August 11, 2021 20:48
@rust-highfive
Copy link

r? @adamgreig

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools labels Aug 11, 2021
@MabezDev MabezDev mentioned this pull request Aug 11, 2021
Merged
burrbull
burrbull previously approved these changes Aug 12, 2021
View reviewed changes
@burrbull
Copy link
Member

Changelog, please.

@MabezDev
Xtensa updates
495c0ec 
* Switch to bare-metal 1.0.0
* Use xtensa-lx `InterruptNumber` trait
* Update CI script
@MabezDev
Copy link
Member Author

Done :)

burrbull
burrbull previously approved these changes Aug 12, 2021
View reviewed changes
@burrbull
Copy link
Member

bors merge

@burrbull
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Aug 12, 2021
@bors @MabezDev
Merge #536
87c12d7 
536: Xtensa updates r=burrbull a=MabezDev

* Switch to bare-metal 1.0.0
* Use xtensa-lx `InterruptNumber` trait
* Update CI script

Co-authored-by: Scott Mabin <scott@mabez.dev>
@bors
Copy link
Contributor

bors bot commented Aug 12, 2021

Build failed:

@burrbull
Copy link
Member

@therealprof Something strange with xml-rs dependency. It doesn't want to be compiled with 1.40.

@adamgreig
Copy link
Member

Ah, it looks like bitflags has been updated from 1.2.1 to 1.3.1 due to xml-rs requiring ^1.0, but bitflags 1.3.1 uses some const fns that bump the effective MSRV.

Now the MSRV is 1.46.0; @MabezDev maybe you could update the MSRV in this PR? Need to change .github/workflows/ci.yaml, .github/bors.toml, and README.md.

adamgreig
adamgreig approved these changes Aug 16, 2021
View reviewed changes
Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let's give it a go.

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 16, 2021

Build succeeded:

@bors bors bot merged commit d6afbf9 into rust-embedded:master Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamgreig adamgreig adamgreig approved these changes

@burrbull burrbull burrbull left review comments

Assignees

@adamgreig adamgreig

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MabezDev @rust-highfive @burrbull @adamgreig