Skip to content

Change changelog check trigger and bump checker version #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 8, 2021
Merged

Change changelog check trigger and bump checker version #530

merged 1 commit into from
Jun 8, 2021

Conversation

therealprof
Copy link
Contributor

No description provided.

@therealprof therealprof requested a review from a team as a code owner June 7, 2021 08:45
@rust-highfive
Copy link

r? @burrbull

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools labels Jun 7, 2021
Emilgardis
Emilgardis approved these changes Jun 8, 2021
View reviewed changes
Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

bors r+

.github/workflows/changelog.yml
@@ -1,5 +1,5 @@
on:
pull_request:
pull_request_target:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sad that this is necessary.

bors bot added a commit that referenced this pull request Jun 8, 2021
@bors @therealprof
Merge #530
e739361 
530: Change changelog check trigger and bump checker version r=Emilgardis a=therealprof



Co-authored-by: Daniel Egger <daniel@eggers-club.de>
@bors
Copy link
Contributor

bors bot commented Jun 8, 2021

Build failed:

@Emilgardis
Copy link
Member

Pretty sure this CI error is due to the fastly cdn outtage

@burrbull
Copy link
Member

burrbull commented Jun 8, 2021

bors retry

@bors
Copy link
Contributor

bors bot commented Jun 8, 2021

Build succeeded:

@bors bors bot merged commit 1969890 into master Jun 8, 2021
@bors bors bot deleted the changelog-check-update branch June 8, 2021 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emilgardis Emilgardis Emilgardis approved these changes

Assignees

@burrbull burrbull

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@therealprof @rust-highfive @Emilgardis @burrbull